From: Guenter Roeck <linux@roeck-us.net>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Sudeep Holla <sudeep.holla@arm.com>,
Jean Delvare <jdelvare@suse.com>,
linux-arm-kernel@lists.infradead.org,
"open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] firmware: arm_scmi: Fetch and store sensor scale
Date: Wed, 8 May 2019 11:33:31 -0700 [thread overview]
Message-ID: <20190508183331.GB25133@roeck-us.net> (raw)
In-Reply-To: <20190508170035.19671-2-f.fainelli@gmail.com>
On Wed, May 08, 2019 at 10:00:34AM -0700, Florian Fainelli wrote:
> In preparation for dealing with scales within the SCMI HWMON driver,
> fetch and store the sensor unit scale into the scmi_sensor_info
> structure. In order to simplify computations for upper layer, take care
> of sign extending the scale to a full 8-bit signed value.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/firmware/arm_scmi/sensors.c | 6 ++++++
> include/linux/scmi_protocol.h | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c
> index b53d5cc9c9f6..21353470a740 100644
> --- a/drivers/firmware/arm_scmi/sensors.c
> +++ b/drivers/firmware/arm_scmi/sensors.c
> @@ -34,6 +34,8 @@ struct scmi_msg_resp_sensor_description {
> __le32 attributes_high;
> #define SENSOR_TYPE(x) ((x) & 0xff)
> #define SENSOR_SCALE(x) (((x) >> 11) & 0x3f)
> +#define SENSOR_SCALE_SIGN BIT(5)
> +#define SENSOR_SCALE_EXTEND GENMASK(7, 6)
> #define SENSOR_UPDATE_SCALE(x) (((x) >> 22) & 0x1f)
> #define SENSOR_UPDATE_BASE(x) (((x) >> 27) & 0x1f)
> u8 name[SCMI_MAX_STR_SIZE];
> @@ -140,6 +142,10 @@ static int scmi_sensor_description_get(const struct scmi_handle *handle,
> s = &si->sensors[desc_index + cnt];
> s->id = le32_to_cpu(buf->desc[cnt].id);
> s->type = SENSOR_TYPE(attrh);
> + s->scale = SENSOR_SCALE(attrh);
> + /* Sign extend to a full s8 */
> + if (s->scale & SENSOR_SCALE_SIGN)
> + s->scale |= SENSOR_SCALE_EXTEND;
> strlcpy(s->name, buf->desc[cnt].name, SCMI_MAX_STR_SIZE);
> }
>
> diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h
> index 3105055c00a7..9ff2e9357e9a 100644
> --- a/include/linux/scmi_protocol.h
> +++ b/include/linux/scmi_protocol.h
> @@ -144,6 +144,7 @@ struct scmi_power_ops {
> struct scmi_sensor_info {
> u32 id;
> u8 type;
> + s8 scale;
> char name[SCMI_MAX_STR_SIZE];
> };
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-05-08 18:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 17:00 [PATCH v4 0/2] hwmon: scmi: Scale values to target desired HWMON units Florian Fainelli
2019-05-08 17:00 ` [PATCH v4 1/2] firmware: arm_scmi: Fetch and store sensor scale Florian Fainelli
2019-05-08 18:33 ` Guenter Roeck [this message]
2019-05-08 17:00 ` [PATCH v4 2/2] hwmon: scmi: Scale values to target desired HWMON units Florian Fainelli
2019-05-08 18:32 ` Guenter Roeck
2019-05-08 18:34 ` Florian Fainelli
2019-05-08 19:40 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508183331.GB25133@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).