Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Marek Vasut <marex@denx.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH V2] net: phy: tja11xx: Add IRQ support to the driver
Date: Thu, 30 May 2019 01:29:30 +0200
Message-ID: <20190529232930.GF18059@lunn.ch> (raw)
In-Reply-To: <fe6c4f2f-812d-61b8-3ffb-7ed7dd89d151@denx.de>

On Tue, May 28, 2019 at 11:33:33PM +0200, Marek Vasut wrote:
> On 5/28/19 11:22 PM, Andrew Lunn wrote:
> >> The link detection on the TJA1100 (not TJA1101) seems unstable at best,
> >> so I better use all the interrupt sources to nudge the PHY subsystem and
> >> have it check the link change.
> > 
> > Then it sounds like you should just ignore interrupts and stay will
> > polling for the TJA1100.
> 
> Polling for the link status change is slow(er) than the IRQ driven
> operation, so I would much rather use the interrupts.

I agree about the speed, but it seems like interrupts on this PHY are
not so reliable. Polling always works. But unfortunately, you cannot
have both interrupts and polling to fix up problems when interrupts
fail. Your call, do you think interrupts really do work?

If you say that tja1101 works as expected, then please just use the
link up/down bits for it.

     Andrew

  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 19:23 Marek Vasut
2019-05-28 19:28 ` Heiner Kallweit
2019-05-28 19:31   ` Marek Vasut
2019-05-28 19:35     ` Heiner Kallweit
2019-05-28 19:46       ` Marek Vasut
2019-05-28 19:58         ` Andrew Lunn
2019-05-28 20:00           ` Marek Vasut
2019-05-28 21:22             ` Andrew Lunn
2019-05-28 21:33               ` Marek Vasut
2019-05-29 23:29                 ` Andrew Lunn [this message]
2019-05-29 23:46                   ` Marek Vasut
2019-06-13 15:42                     ` Marek Vasut
2019-06-17 17:16                       ` Andrew Lunn
2019-06-17 17:43                         ` Marek Vasut

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190529232930.GF18059@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox