Linux-Hwmon Archive on lore.kernel.org
 help / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Luca Tettamanti <kronos.it@gmail.com>,
	Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: asus_atk0110: no need to check return value of debugfs_create functions
Date: Wed, 12 Jun 2019 05:38:06 -0700
Message-ID: <20190612123806.GA15512@roeck-us.net> (raw)
In-Reply-To: <20190611175858.GA10077@kroah.com>

On Tue, Jun 11, 2019 at 07:58:58PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Cc: Luca Tettamanti <kronos.it@gmail.com>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-hwmon@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/asus_atk0110.c | 23 +++--------------------
>  1 file changed, 3 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
> index 22be78cc5a4c..b5f0abde916b 100644
> --- a/drivers/hwmon/asus_atk0110.c
> +++ b/drivers/hwmon/asus_atk0110.c
> @@ -789,33 +789,16 @@ static const struct file_operations atk_debugfs_ggrp_fops = {
>  static void atk_debugfs_init(struct atk_data *data)
>  {
>  	struct dentry *d;
> -	struct dentry *f;
>  
>  	data->debugfs.id = 0;
>  
>  	d = debugfs_create_dir("asus_atk0110", NULL);
> -	if (!d || IS_ERR(d))
> -		return;
>  
> -	f = debugfs_create_x32("id", 0600, d, &data->debugfs.id);
> -	if (!f || IS_ERR(f))
> -		goto cleanup;
> -
> -	f = debugfs_create_file_unsafe("gitm", 0400, d, data,
> -				       &atk_debugfs_gitm);
> -	if (!f || IS_ERR(f))
> -		goto cleanup;
> -
> -	f = debugfs_create_file("ggrp", 0400, d, data,
> -				&atk_debugfs_ggrp_fops);
> -	if (!f || IS_ERR(f))
> -		goto cleanup;
> +	debugfs_create_x32("id", 0600, d, &data->debugfs.id);
> +	debugfs_create_file_unsafe("gitm", 0400, d, data, &atk_debugfs_gitm);
> +	debugfs_create_file("ggrp", 0400, d, data, &atk_debugfs_ggrp_fops);
>  
>  	data->debugfs.root = d;
> -
> -	return;
> -cleanup:
> -	debugfs_remove_recursive(d);
>  }
>  
>  static void atk_debugfs_cleanup(struct atk_data *data)

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 17:58 Greg Kroah-Hartman
2019-06-12 12:38 ` Guenter Roeck [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612123806.GA15512@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jdelvare@suse.com \
    --cc=kronos.it@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox