From: Rob Herring <robh@kernel.org>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Serge Semin <Sergey.Semin@t-platforms.ru>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add DT bindings for TI ads1000/ads1100 ADCs
Date: Thu, 13 Jun 2019 14:33:13 -0600 [thread overview]
Message-ID: <20190613203313.GA23102@bogus> (raw)
In-Reply-To: <20190514225810.12591-2-fancer.lancer@gmail.com>
On Wed, May 15, 2019 at 01:58:08AM +0300, Serge Semin wrote:
> Add dt-binding documentation for the Texas Instruments ads1000/ads1100 ADCs
> driver.
>
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
> ---
> .../devicetree/bindings/hwmon/ads1000.txt | 61 ++++++++++++++++
Bindings should be separate patch.
> Documentation/hwmon/ads1000.rst | 72 +++++++++++++++++++
> 2 files changed, 133 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/ads1000.txt
> create mode 100644 Documentation/hwmon/ads1000.rst
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ads1000.txt b/Documentation/devicetree/bindings/hwmon/ads1000.txt
> new file mode 100644
> index 000000000000..3907b7da9b33
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ads1000.txt
> @@ -0,0 +1,61 @@
> +ADS1000/ADS1100 (I2C)
> +
> +This device is a 12-16 bit A-D converter with 1 input.
ADC's should be in bindings/iio/adc/
> +
> +The inputs can be used either as a differential pair of Vin+ Vin- or as a single
> +ended sensor for Vin+ GND. The inputs mode is platform-dependent and isn't
> +configured by software in any case.
> +
> +Device A-D converter sensitivity can be configured using two parameters:
> + - pga is the programmable gain amplifier
> + 0: x1 (default)
> + 1: x2
> + 2: x4
> + 3: x8
> + - data_rate in samples per second also affecting the output code accuracy
> + 0: 128SPS - +/- Vdd*0.488mV (default, ads1000 accepts this rate only)
> + 1: 32SPS - +/- Vdd*0.122mV
> + 2: 16SPS - +/- Vdd*0.061mV
> + 3: 8SPS - +/- Vdd*0.030mV
> + Since this parameter also affects the output accuracy, be aware the greater
> + SPS the worse accuracy.
> +
> +As a result the output value is calculated by the next formulae:
> +dVin = Cod * Vdd / (PGA * max(|Cod|)), where
> +max(|Cod|) - maximum possible value of the output code, which depends on the SPS
> +setting from the table above.
> +
> +The ADS1000/ADS1100 dts-node:
> +
> + Required properties:
> + - compatible : must be "ti,ads1000" or "ti,ads1100"
> + - reg : I2C bus address of the device
> + - #address-cells : must be <1>
> + - #size-cells : must be <0>
> + - vdd-supply : regulator for reference supply voltage (usually fixed)
> +
> + Optional properties:
> + - ti,gain : the programmable gain amplifier setting
> + - ti,datarate : the converter data rate
IIRC, we have standard properties for these.
> + - ti,voltage-divider : <R1 R2> Ohms inbound voltage dividers,
> + so dVin = (R1 + R2)/R2 * dVin
> +
> +Example:
> +
> +vdd_5v0: fixedregulator@0 {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd-ref";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> +};
> +
> +tiadc: ads1000@48 {
adc@48
> + compatible = "ti,ads1000";
> + reg = <0x48>;
> +
> + vdd-supply = <&vdd_5v0>;
> + ti,gain = <0>;
> + ti,voltage-divider = <31600 3600>;
> +};
> +
next prev parent reply other threads:[~2019-06-13 20:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 22:58 [PATCH 0/2] hwmon: Add TI ads1000/ads1100 driver package Serge Semin
2019-05-14 22:58 ` [PATCH 1/2] dt-bindings: hwmon: Add DT bindings for TI ads1000/ads1100 ADCs Serge Semin
2019-06-13 20:33 ` Rob Herring [this message]
2019-06-14 6:04 ` Serge Semin
2019-05-14 22:58 ` [PATCH 2/2] hwmon: Add ads1000/ads1100 voltage ADCs driver Serge Semin
2019-05-30 12:55 ` Guenter Roeck
2019-06-03 11:11 ` Jonathan Cameron
2019-06-05 20:55 ` Guenter Roeck
2019-06-07 23:01 ` Serge Semin
2019-06-08 1:02 ` Guenter Roeck
2019-06-10 14:57 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613203313.GA23102@bogus \
--to=robh@kernel.org \
--cc=Sergey.Semin@t-platforms.ru \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).