* Re: [v2 2/9] hwmon: (nct7904) Changes comments in probe function.
@ 2019-06-28 17:29 Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2019-06-28 17:29 UTC (permalink / raw)
To: Amy.Shih
Cc: she90122, oakley.ding, jia.sui, Jean Delvare, linux-hwmon, linux-kernel
On Mon, Jun 17, 2019 at 08:10:00AM +0000, Amy.Shih@advantech.com.tw wrote:
> From: "amy.shih" <amy.shih@advantech.com.tw>
>
> Linux style for comments is the C89 "/* ... */" style,
> changes the comments to Linux style.
>
> Signed-off-by: amy.shih <amy.shih@advantech.com.tw>
Applied.
Thanks,
Guenter
> ---
> Changes in v2:
> - Fix wrong style of comments.
>
> drivers/hwmon/nct7904.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 401ed4a4a576..710c30562fc1 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -542,13 +542,13 @@ static int nct7904_probe(struct i2c_client *client,
> if (ret < 0)
> return ret;
> if (ret & 0x80) {
> - data->enable_dts = 1; //Enable DTS & PECI
> + data->enable_dts = 1; /* Enable DTS & PECI */
> } else {
> ret = nct7904_read_reg(data, BANK_2, TSI_CTRL_REG);
> if (ret < 0)
> return ret;
> if (ret & 0x80)
> - data->enable_dts = 0x3; //Enable DTS & TSI
> + data->enable_dts = 0x3; /* Enable DTS & TSI */
> }
>
> /* Check DTS enable status */
^ permalink raw reply [flat|nested] 2+ messages in thread
* [v2 2/9] hwmon: (nct7904) Changes comments in probe function.
2019-06-17 8:08 [v2 1/9] hwmon: (nct7904) Add error handling " Amy.Shih
@ 2019-06-17 8:10 ` Amy.Shih
0 siblings, 0 replies; 2+ messages in thread
From: Amy.Shih @ 2019-06-17 8:10 UTC (permalink / raw)
To: she90122
Cc: amy.shih, oakley.ding, jia.sui, Jean Delvare, Guenter Roeck,
linux-hwmon, linux-kernel
From: "amy.shih" <amy.shih@advantech.com.tw>
Linux style for comments is the C89 "/* ... */" style,
changes the comments to Linux style.
Signed-off-by: amy.shih <amy.shih@advantech.com.tw>
---
Changes in v2:
- Fix wrong style of comments.
drivers/hwmon/nct7904.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
index 401ed4a4a576..710c30562fc1 100644
--- a/drivers/hwmon/nct7904.c
+++ b/drivers/hwmon/nct7904.c
@@ -542,13 +542,13 @@ static int nct7904_probe(struct i2c_client *client,
if (ret < 0)
return ret;
if (ret & 0x80) {
- data->enable_dts = 1; //Enable DTS & PECI
+ data->enable_dts = 1; /* Enable DTS & PECI */
} else {
ret = nct7904_read_reg(data, BANK_2, TSI_CTRL_REG);
if (ret < 0)
return ret;
if (ret & 0x80)
- data->enable_dts = 0x3; //Enable DTS & TSI
+ data->enable_dts = 0x3; /* Enable DTS & TSI */
}
/* Check DTS enable status */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-28 17:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-28 17:29 [v2 2/9] hwmon: (nct7904) Changes comments in probe function Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2019-06-17 8:08 [v2 1/9] hwmon: (nct7904) Add error handling " Amy.Shih
2019-06-17 8:10 ` [v2 2/9] hwmon: (nct7904) Changes comments " Amy.Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).