linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Björn Gerhart" <gerhart@posteo.de>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH] hwmon: (nct6775) Fix register address and added missing tolerance
Date: Wed, 10 Jul 2019 14:00:33 -0700	[thread overview]
Message-ID: <20190710210033.GA8098@roeck-us.net> (raw)
In-Reply-To: <C4783F82-7655-4997-AE0E-496683FE1C8B@posteo.de>

Hi Bjoern,

On Wed, Jul 10, 2019 at 09:08:56PM +0200, Björn Gerhart wrote:
> In the process of adding the new model nct6116, two tiny details of the nct6106 attracted my attention. Please find the patch therefore below:
> 

Please sign your patches. Also, what is your baseline kernel version ?
The patch doesn't apply to the current mainline kernel.

Thanks,
Guenter

> Index: nct6775.c
> ===================================================================
> --- nct6775.c	(revision 16326)
> +++ nct6775.c	(working copy)
> @@ -866,7 +866,7 @@
>  static const u16 NCT6106_REG_WEIGHT_TEMP_SEL[] = { 0x168, 0x178, 0x188 };
>  static const u16 NCT6106_REG_WEIGHT_TEMP_STEP[] = { 0x169, 0x179, 0x189 };
>  static const u16 NCT6106_REG_WEIGHT_TEMP_STEP_TOL[] = { 0x16a, 0x17a, 0x18a };
> -static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x17c };
> +static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x18b };
>  static const u16 NCT6106_REG_WEIGHT_TEMP_BASE[] = { 0x16c, 0x17c, 0x18c };
>  static const u16 NCT6106_REG_WEIGHT_DUTY_BASE[] = { 0x16d, 0x17d, 0x18d };
>  
> @@ -3778,6 +3778,7 @@
>  		data->REG_FAN_TIME[0] = NCT6106_REG_FAN_STOP_TIME;
>  		data->REG_FAN_TIME[1] = NCT6106_REG_FAN_STEP_UP_TIME;
>  		data->REG_FAN_TIME[2] = NCT6106_REG_FAN_STEP_DOWN_TIME;
> +		data->REG_TOLERANCE_H = NCT6106_REG_TOLERANCE_H;
>  		data->REG_PWM[0] = NCT6106_REG_PWM;
>  		data->REG_PWM[1] = NCT6106_REG_FAN_START_OUTPUT;
>  		data->REG_PWM[2] = NCT6106_REG_FAN_STOP_OUTPUT;

  reply	other threads:[~2019-07-10 21:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 19:08 [PATCH] hwmon: (nct6775) Fix register address and added missing tolerance Björn Gerhart
2019-07-10 21:00 ` Guenter Roeck [this message]
2019-07-15 16:33 ` [PATCH] hwmon: (nct6775) Fix register address and added missed tolerance for nct6106 Björn Gerhart
2019-07-15 17:46   ` Guenter Roeck
2019-07-15 17:48     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190710210033.GA8098@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=gerhart@posteo.de \
    --cc=linux-hwmon@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).