From: Guenter Roeck <linux@roeck-us.net>
To: John Wang <wangzqbj@inspur.com>
Cc: jdelvare@suse.com, corbet@lwn.net, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
miltonm@us.ibm.com, Yu Lei <mine260309@gmail.com>,
duanzhijia01@inspur.com, Joel Stanley <joel@jms.id.au>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v3 2/2] hwmon: pmbus: Add Inspur Power System power supply driver
Date: Mon, 12 Aug 2019 12:33:15 -0700 [thread overview]
Message-ID: <20190812193315.GA25520@roeck-us.net> (raw)
In-Reply-To: <CAHkHK0_wts97mEjSOpZrKU8bTWKzh0+HBxTg0fSmdkFBsrWjFA@mail.gmail.com>
On Mon, Aug 12, 2019 at 12:48:34PM +0800, John Wang wrote:
>
> So I should
>
> 1. Add SENSOR_INSPUR_IPSPS to the end of the file
> 2. Add SENSOR_INSPUR_IPSPS in alphabetical order, without additional tab
> 3. other suggestions
>
I would suggest 2). Just use a space before += instead of a tab.
Guenter
prev parent reply other threads:[~2019-08-12 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 2:53 [PATCH v3 2/2] hwmon: pmbus: Add Inspur Power System power supply driver John Wang
2019-08-12 4:21 ` Guenter Roeck
2019-08-12 4:48 ` John Wang
2019-08-12 19:33 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812193315.GA25520@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=duanzhijia01@inspur.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@us.ibm.com \
--cc=mine260309@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=wangzqbj@inspur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).