From: Wolfram Sang <wsa@the-dreams.de>
To: Max Staudt <max@enpas.org>
Cc: linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
glaubitz@physik.fu-berlin.de
Subject: Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga
Date: Wed, 14 Aug 2019 21:47:14 +0200 [thread overview]
Message-ID: <20190814194714.GB9756@kunai> (raw)
In-Reply-To: <20190812235237.21797-1-max@enpas.org>
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
Hi,
Thanks for the patch. It looks mostly good.
> +static int clock = 0x1c;
> +module_param(clock, int, 0444);
'clock' determines the bus speed?
> + i2c->adapter.class = I2C_CLASS_DEPRECATED;
This is only needed for drivers which used to have a class and decided
to drop it. You can leave it empty.
> + algo_data->data = (void *)i2c;
You don't need the cast, do you?
> +MODULE_LICENSE("GPL");
Your SPDX header says GPL 2.0 only.
Kind regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-14 19:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 23:52 [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Max Staudt
2019-08-12 23:52 ` [PATCH v2 2/4] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision Max Staudt
2019-08-13 7:03 ` Geert Uytterhoeven
2019-08-13 9:49 ` Max Staudt
2019-08-14 19:52 ` Wolfram Sang
2019-08-12 23:52 ` [PATCH v2 3/4] hwmon/ltc2990: Add platform_data support Max Staudt
2019-08-13 6:59 ` Geert Uytterhoeven
2019-08-13 8:02 ` Guenter Roeck
2019-08-13 8:27 ` Geert Uytterhoeven
2019-08-13 13:27 ` Guenter Roeck
2019-08-13 13:32 ` Geert Uytterhoeven
2019-08-13 10:10 ` Max Staudt
2019-08-13 13:24 ` Guenter Roeck
2019-08-13 13:31 ` Max
2019-08-14 18:11 ` Max Staudt
2019-08-12 23:52 ` [PATCH v2 4/4] i2c/busses/i2c-icy: Add platform_data for LTC2990 Max Staudt
2019-08-13 7:04 ` Geert Uytterhoeven
2019-08-13 7:08 ` [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Geert Uytterhoeven
2019-08-13 9:50 ` Max Staudt
2019-08-14 19:47 ` Wolfram Sang [this message]
2019-08-14 22:33 ` Max Staudt
2019-08-15 7:12 ` Wolfram Sang
2019-08-15 10:00 ` Max Staudt
2019-08-15 11:48 ` Wolfram Sang
2019-08-15 11:52 ` Max
2019-08-15 12:04 ` Wolfram Sang
2019-08-15 12:10 ` Max Staudt
2019-08-15 12:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814194714.GB9756@kunai \
--to=wsa@the-dreams.de \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=max@enpas.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).