Hi, Thanks for the patch. It looks mostly good. > +static int clock = 0x1c; > +module_param(clock, int, 0444); 'clock' determines the bus speed? > + i2c->adapter.class = I2C_CLASS_DEPRECATED; This is only needed for drivers which used to have a class and decided to drop it. You can leave it empty. > + algo_data->data = (void *)i2c; You don't need the cast, do you? > +MODULE_LICENSE("GPL"); Your SPDX header says GPL 2.0 only. Kind regards, Wolfram