From: Borislav Petkov <bp@alien8.de>
To: Isaac Vaughn <isaac.vaughn@Knights.ucf.edu>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
"trivial@kernel.org" <trivial@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
x86@kernel.org, linux-hwmon@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] Add PCI device IDs for family 17h, model 70h
Date: Fri, 6 Sep 2019 14:14:31 +0200 [thread overview]
Message-ID: <20190906121431.GC19008@zn.tnic> (raw)
In-Reply-To: <20190906075729.9e2faf7147da62fc26006833@knights.ucf.edu>
On Fri, Sep 06, 2019 at 11:57:35AM +0000, Isaac Vaughn wrote:
> Will do, thanks.
And, when you reply to mails, please press "Reply-to-all" in your mail
client and do not do private mails. There's a reason there's a Cc list.
Readding them.
> I built my patch on both 5.3.0rc7 and master, and have tested and
> am currently running it on 5.3.0rc7. Which tag are you building
> on? I suspect there is a version mismatch since ".dbam_to_cs =
> f17_base_addr_to_cs_size" is on line 2262 for me and a recursive grep
> of the entire returned no results for "f17_addr_mask_to_cs_size".
Ah, yes, you couldn't have known that, lemme explain.
So almost all maintainers have one or more branches which contain the
work scheduled to go to Linus in the next merge window and that work is
being merged on a daily basis into linux-next.
The EDAC branch which has that is edac-for-next in the repo
git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git
Please use that one to base your patch on.
That branch also has a previous patch which does this:
-static int f17_base_addr_to_cs_size(struct amd64_pvt *pvt, u8 umc,
+static int f17_addr_mask_to_cs_size(struct amd64_pvt *pvt, u8 umc,
which explains the failure.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2019-09-06 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BN7PR07MB5186DD5732B95B784A9D46BFCEB80@BN7PR07MB5186.namprd07.prod.outlook.com>
[not found] ` <20190904215308.GA12374@zn.tnic>
[not found] ` <BN7PR07MB5186E542BB3AD734262AA345CEBB0@BN7PR07MB5186.namprd07.prod.outlook.com>
[not found] ` <20190905070917.GA19246@zn.tnic>
[not found] ` <BN7PR07MB51864F8287CAD4847BF17A83CEBB0@BN7PR07MB5186.namprd07.prod.outlook.com>
[not found] ` <20190905135408.GE19246@zn.tnic>
[not found] ` <20190905215650.f8b5d22b625ddcff7d093883@knights.ucf.edu>
2019-09-06 9:12 ` [PATCH] Add PCI device IDs for family 17h, model 70h Borislav Petkov
[not found] ` <20190906075729.9e2faf7147da62fc26006833@knights.ucf.edu>
2019-09-06 12:14 ` Borislav Petkov [this message]
2019-09-06 13:02 ` Guenter Roeck
2019-09-06 13:09 ` Boris Petkov
[not found] ` <B08C8E54-43FA-4E29-8D7D-5F9C4AF20CCF@Knights.ucf.edu>
2019-09-06 14:50 ` Borislav Petkov
2019-09-06 23:27 ` Isaac Vaughn
2019-09-06 16:11 ` Guenter Roeck
2019-09-06 16:22 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906121431.GC19008@zn.tnic \
--to=bp@alien8.de \
--cc=isaac.vaughn@Knights.ucf.edu \
--cc=linux-edac@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).