Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: ABI for these two registers?
Date: Thu, 12 Sep 2019 14:09:58 -0700
Message-ID: <20190912210957.GA21945@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20190912183218.GA5065@roeck-us.net>

Hello Guenter,

On Thu, Sep 12, 2019 at 11:32:18AM -0700, Guenter Roeck wrote:
> On Wed, Sep 11, 2019 at 05:28:14PM -0700, Nicolin Chen wrote:
> > Hello Guenter,
> > 
> > Datasheet: http://www.ti.com/lit/ds/symlink/ina3221.pdf
> > (At page 32, chapter 8.6.2.14 and 8.6.2.15)
> > 
> > I have two registers that I need to expose to user space:
> > 	Shunt-Voltage-Sum and Shunt-Voltage-Limit registers
> > 
> > Right now in[123]_input of INA3221 are for voltage channels
> > while in[456]_input are for Shunt voltage channels.
> > 
> > So can I just use in7_input and in7_crit for them?
> > 
> Doesn't Shunt-Voltage-Limit apply to in[456]_input ?
> If so, the limit should be attached to those.

The initial patch of ina3221 driver applied Shunt-Voltage-Limits,
being named as "Critical Alert Limit Registers" in the datasheet,
to curr[123]_crit, corresponding to curr[123] and in[456]_input.

And this Shunt-Voltage-Limit-Sum is more related to the reading
from Shunt-Voltage-Sum, which we just agreed it to be in7_input.

Do you mean that this Limit-Sum should become in[456]_crit even
though it only has one value, related to sum of all three shunt
voltage channels?

> in7_input for Shunt-Voltage-Sum would be fine.

Okay. Will add in7_input for Shunt-Voltage-Sum. Thanks!

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  0:28 Nicolin Chen
2019-09-12 18:32 ` Guenter Roeck
2019-09-12 21:09   ` Nicolin Chen [this message]
2019-09-12 22:09     ` Guenter Roeck
2019-09-12 22:45       ` Nicolin Chen
2019-09-13  0:12         ` Nicolin Chen

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190912210957.GA21945@Asurada-Nvidia.nvidia.com \
    --to=nicoleotsuka@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox