From: Guenter Roeck <linux@roeck-us.net>
To: Colin King <colin.king@canonical.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: abituguru: make array probe_order static, makes object smaller
Date: Sun, 6 Oct 2019 08:34:09 -0700 [thread overview]
Message-ID: <20191006153409.GA7882@roeck-us.net> (raw)
In-Reply-To: <20191006145231.24022-1-colin.king@canonical.com>
On Sun, Oct 06, 2019 at 03:52:31PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array probe_order on the stack but instead make it
> static. Makes the object code smaller by 94 bytes.
>
> Before:
> text data bss dec hex filename
> 41473 13448 320 55241 d7c9 drivers/hwmon/abituguru.o
>
> After:
> text data bss dec hex filename
> 41315 13512 320 55147 d76b drivers/hwmon/abituguru.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/abituguru.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/abituguru.c b/drivers/hwmon/abituguru.c
> index a5cf6b2a6e49..681f0623868f 100644
> --- a/drivers/hwmon/abituguru.c
> +++ b/drivers/hwmon/abituguru.c
> @@ -1264,7 +1264,7 @@ static int abituguru_probe(struct platform_device *pdev)
> * El weirdo probe order, to keep the sysfs order identical to the
> * BIOS and window-appliction listing order.
> */
> - const u8 probe_order[ABIT_UGURU_MAX_BANK1_SENSORS] = {
> + static const u8 probe_order[ABIT_UGURU_MAX_BANK1_SENSORS] = {
> 0x00, 0x01, 0x03, 0x04, 0x0A, 0x08, 0x0E, 0x02,
> 0x09, 0x06, 0x05, 0x0B, 0x0F, 0x0D, 0x07, 0x0C };
>
prev parent reply other threads:[~2019-10-06 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 14:52 [PATCH] hwmon: abituguru: make array probe_order static, makes object smaller Colin King
2019-10-06 15:12 ` Hans de Goede
2019-10-06 15:34 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006153409.GA7882@roeck-us.net \
--to=linux@roeck-us.net \
--cc=colin.king@canonical.com \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).