linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jakub Ladman <ladmanj@volny.cz>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH][RESEND] New driver for TLV493D-A1B6 I2C chip, input and hwmon class device.
Date: Fri, 18 Oct 2019 13:56:37 -0700	[thread overview]
Message-ID: <20191018205637.GS35946@dtor-ws> (raw)
In-Reply-To: <966f09b8-0936-6d90-2ec8-bcb1b94c81aa@volny.cz>

Hi Jakub,

On Fri, Oct 18, 2019 at 10:10:19PM +0200, Jakub Ladman wrote:
> Dear maintainers.
> 
> As a linux-patch newbie i made some mistakes in my first attempt to send
> this patch.
> This patch contains a new driver for i2c connected chip, Infineon
> TLV493D-A1B6.
> The chip is 3D hall-effect sensor with thermometer.
> 
> This particular driver senses magnetic field rotation in X/Y plane with 1
> degree resolution and +/- 1 degree error.
> 
> Input device is created for the angle sensing part.
> Hwmon device is created for the thermometer part.
> 
> Input device axis must be configured by device-tree. There are also optional
> parameters regarding absolute/relative mode switching, minimum step in
> relative mode, filtering and thermometer calibration.
> 
> We are using that device as high reliability rotary encoder.

I wonder if IIO subsystem that support s magnetometers and temperature
sensors would not be a better hone for this.

CC-ing Jonathan.

Also, your mailer mangled your patch pretty badly, please consider using
git send-email next time.

Thanks.

-- 
Dmitry

  reply	other threads:[~2019-10-18 20:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 20:10 [PATCH][RESEND] New driver for TLV493D-A1B6 I2C chip, input and hwmon class device Jakub Ladman
2019-10-18 20:56 ` Dmitry Torokhov [this message]
2019-10-28 13:05   ` Jonathan Cameron
2019-10-18 21:01 Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191018205637.GS35946@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ladmanj@volny.cz \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).