From: Guenter Roeck <linux@roeck-us.net>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (ina3221) Fix read timeout issue
Date: Mon, 28 Oct 2019 18:47:12 -0700 [thread overview]
Message-ID: <20191029014712.GA22268@roeck-us.net> (raw)
In-Reply-To: <20191022005922.30239-1-nicoleotsuka@gmail.com>
On Mon, Oct 21, 2019 at 05:59:22PM -0700, Nicolin Chen wrote:
> After introducing "samples" to the calculation of wait time, the
> driver might timeout at the regmap_field_read_poll_timeout call,
> because the wait time could be longer than the 100000 usec limit
> due to a large "samples" number.
>
> So this patch sets the timeout limit to 2 times of the wait time
> in order to fix this issue.
>
> Fixes: 5c090abf945b ("hwmon: (ina3221) Add averaging mode support")
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/ina3221.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
> index ef37479991be..f335d0cb0c77 100644
> --- a/drivers/hwmon/ina3221.c
> +++ b/drivers/hwmon/ina3221.c
> @@ -213,7 +213,7 @@ static inline int ina3221_wait_for_data(struct ina3221_data *ina)
>
> /* Polling the CVRF bit to make sure read data is ready */
> return regmap_field_read_poll_timeout(ina->fields[F_CVRF],
> - cvrf, cvrf, wait, 100000);
> + cvrf, cvrf, wait, wait * 2);
> }
>
> static int ina3221_read_value(struct ina3221_data *ina, unsigned int reg,
prev parent reply other threads:[~2019-10-29 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 0:59 [PATCH] hwmon: (ina3221) Fix read timeout issue Nicolin Chen
2019-10-29 1:47 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029014712.GA22268@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).