From: Logan Shaw <logan.shaw@alliedtelesis.co.nz>
To: linux@roeck-us.net, jdelvare@suse.com, robh+dt@kernel.org
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Joshua.Scott@alliedtelesis.co.nz,
Chris.Packham@alliedtelesis.co.nz,
logan.shaw@alliedtelesis.co.nz
Subject: [PATCH v3 0/2] hwmon: (adt7475) Added attenuator bypass support
Date: Fri, 17 Jan 2020 16:50:16 +1300 [thread overview]
Message-ID: <20200117035018.11985-1-logan.shaw@alliedtelesis.co.nz> (raw)
The ADT7473 and ADT7475 support bypassing voltage input attenuators on
voltage input 1 and the ADT7476 and ADT7490 additionally support
bypassing voltage input attenuators on voltage inputs 0, 3, and 4. This
can be useful to improve measurement resolution when measuring voltages
0 V - 2.25 V.
This patch adds 4 optional devicetree properties to the adt7475
driver, each setting the attenuator bypass (or clearing) on a
specific voltage input.
* v3
- removed the functionality to set the global attenuator bypass.
- added functionality to allow bypassing voltage input 1 on the
ADT7473 and ADT7475.
- added DTS definition file adt7475.yaml and 4 new properties.
- added the previousely missing newline character to the end of
file adt7475.c.
* v2
- removed sysfs changes from patch
- removed adt7475_write macro from patch and replaced it by using
the i2c_smbus_write_byte_data function directly in code.
- removed config4_attenuate_index function from patch and replaced it
by modifying the function load_individual_bypass_attenuators
to use hard coded bit values.
- modified function load_individual_bypass_attenuators to use 4 if
statements, one for each voltage input, replacing the for loop.
- modified function adt7475_probe to check the device is a ADT7476 or
ADT7490 (other devices do not support bypassing all or
individual attenuators), and only then set the relevant bits.
- added new file adt7475.txt to document the new devicetree properties.
- removed c++ style comments.
Logan Shaw (2):
hwmon: (adt7475) Added attenuator bypass support
hwmon: (adt7475) Added attenuator bypass support
.../devicetree/bindings/hwmon/adt7475.yaml | 90 +++++++++++++++++++
drivers/hwmon/adt7475.c | 76 ++++++++++++++++
2 files changed, 166 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/adt7475.yaml
--
2.25.0
next reply other threads:[~2020-01-17 3:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 3:50 Logan Shaw [this message]
2020-01-17 3:50 ` [PATCH v3 1/2] hwmon: (adt7475) Added attenuator bypass support Logan Shaw
2020-01-17 3:50 ` [PATCH v3 2/2] " Logan Shaw
2020-01-17 16:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117035018.11985-1-logan.shaw@alliedtelesis.co.nz \
--to=logan.shaw@alliedtelesis.co.nz \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=Joshua.Scott@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).