From: Guenter Roeck <linux@roeck-us.net>
To: "Ondrej Čerman" <ocerman@sda1.eu>
Cc: linux-hwmon@vger.kernel.org, Clemens Ladisch <clemens@ladisch.de>,
Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH 0/4] hwmon: k10temp driver improvements
Date: Fri, 17 Jan 2020 10:46:17 -0800 [thread overview]
Message-ID: <20200117184617.GD13396@roeck-us.net> (raw)
In-Reply-To: <e452614a-5425-e77c-4e2f-2a17ca733b7f@sda1.eu>
On Fri, Jan 17, 2020 at 10:46:25AM +0100, Ondrej Čerman wrote:
> Dňa 16. 1. 2020 o 15:17 Guenter Roeck napísal(a):
> > This patch series implements various improvements for the k10temp driver.
> >
> > Patch 1/4 introduces the use of bit operations.
> >
> > Patch 2/4 converts the driver to use the devm_hwmon_device_register_with_info
> > API. This not only simplifies the code and reduces its size, it also
> > makes the code easier to maintain and enhance.
> >
> > Patch 3/4 adds support for reporting Core Complex Die (CCD) temperatures
> > on Ryzen 3 (Zen2) CPUs.
> >
> > Patch 4/4 adds support for reporting core and SoC current and voltage
> > information on Ryzen CPUs.
> >
> > With all patches in place, output on Ryzen 3900 CPUs looks as follows
> > (with the system under load).
> >
> > k10temp-pci-00c3
> > Adapter: PCI adapter
> > Vcore: +1.36 V
> > Vsoc: +1.18 V
> > Tdie: +86.8°C (high = +70.0°C)
> > Tctl: +86.8°C
> > Tccd1: +80.0°C
> > Tccd2: +81.8°C
> > Icore: +44.14 A
> > Isoc: +13.83 A
> >
> > The patch series has only been tested with Ryzen 3900 CPUs. Further test
> > coverage will be necessary before the changes can be applied to the Linux
> > kernel.
> >
> Hello everyone, I am the author of https://github.com/ocerman/zenpower/ .
>
> It is nice to see this merged.
>
> I just want to warn you that there have been reported issues with
> Threadripper CPUs to zenpower issue tracker. Also I think that no-one tested
> EPYC CPUs.
>
> Most of the stuff I was able to figure out by trial-and-error approach and
> unfortunately because I do not own any Threadripper CPU I was not able to
> test and fix reported problems.
>
Thanks a lot for the note. The key problem seems to be that Threadripper
doesn't report SoC current and voltage. Is that correct ? If so, that
should be easy to solve.
On a side note, drivers/gpu/drm/amd/include/asic_reg/thm/thm_10_0_offset.h
suggests that two more temperature sensors might be available at 0x0005995C
and 0x00059960 (DIE3_TEMP and SW_TEMP). Have you ever tried that ?
Thanks,
Guenter
next prev parent reply other threads:[~2020-01-17 18:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 14:17 [RFT PATCH 0/4] hwmon: k10temp driver improvements Guenter Roeck
2020-01-16 14:17 ` [RFT PATCH 1/4] hwmon: (k10temp) Use bitops Guenter Roeck
2020-01-16 14:17 ` [RFT PATCH 2/4] hmon: (k10temp) Convert to use devm_hwmon_device_register_with_info Guenter Roeck
2020-01-16 14:17 ` [RFT PATCH 3/4] hwmon: (k10temp) Report temperatures per CPU die Guenter Roeck
2020-01-16 14:18 ` [RFT PATCH 4/4] hwmon: (k10temp) Show core and SoC current and voltages on Zen CPUs Guenter Roeck
2020-01-16 20:55 ` [RFT PATCH 0/4] hwmon: k10temp driver improvements Darren Salt
2020-01-16 21:11 ` Guenter Roeck
2020-01-16 22:46 ` Bernhard Gebetsberger
2020-01-16 22:52 ` Guenter Roeck
2020-01-17 0:38 ` Ken Moffat
2020-01-17 3:58 ` Guenter Roeck
2020-01-17 4:47 ` Ken Moffat
2020-01-17 14:14 ` Guenter Roeck
2020-01-17 18:58 ` Ken Moffat
2020-01-17 9:46 ` Ondrej Čerman
2020-01-17 18:46 ` Guenter Roeck [this message]
2020-01-17 22:48 ` Ondrej Čerman
2020-01-17 9:58 ` Holger Kiehl
2020-01-17 19:15 ` Sebastian Reichel
2020-01-18 8:52 ` Brad Campbell
2020-01-18 17:14 ` Guenter Roeck
2020-01-19 1:59 ` Brad Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117184617.GD13396@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clemens@ladisch.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ocerman@sda1.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).