From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, Clemens Ladisch <clemens@ladisch.de>,
Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH 0/4] hwmon: k10temp driver improvements
Date: Fri, 17 Jan 2020 20:15:17 +0100 [thread overview]
Message-ID: <20200117191517.pp4vqzkectju4mnd@earth.universe> (raw)
In-Reply-To: <20200116141800.9828-1-linux@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 2918 bytes --]
Hi,
On Thu, Jan 16, 2020 at 06:17:56AM -0800, Guenter Roeck wrote:
> This patch series implements various improvements for the k10temp driver.
>
> Patch 1/4 introduces the use of bit operations.
>
> Patch 2/4 converts the driver to use the devm_hwmon_device_register_with_info
> API. This not only simplifies the code and reduces its size, it also
> makes the code easier to maintain and enhance.
>
> Patch 3/4 adds support for reporting Core Complex Die (CCD) temperatures
> on Ryzen 3 (Zen2) CPUs.
>
> Patch 4/4 adds support for reporting core and SoC current and voltage
> information on Ryzen CPUs.
>
> With all patches in place, output on Ryzen 3900 CPUs looks as follows
> (with the system under load).
>
> k10temp-pci-00c3
> Adapter: PCI adapter
> Vcore: +1.36 V
> Vsoc: +1.18 V
> Tdie: +86.8°C (high = +70.0°C)
> Tctl: +86.8°C
> Tccd1: +80.0°C
> Tccd2: +81.8°C
> Icore: +44.14 A
> Isoc: +13.83 A
>
> The patch series has only been tested with Ryzen 3900 CPUs. Further test
> coverage will be necessary before the changes can be applied to the Linux
> kernel.
Looks ok on 3800X (idle):
$ lscpu | grep "Model name"
Model name: AMD Ryzen 7 3800X 8-Core Processor
$ sensors "k10temp-*"
k10temp-pci-00c3
Adapter: PCI adapter
Vcore: 937.00 mV
Vsoc: 1.01 V
Tdie: +35.2°C (high = +70.0°C)
Tctl: +35.2°C
Tccd1: +35.8°C
Icore: 4.61 A
Isoc: 6.18 A
And after compiling the kernel with 32 threads for 1 minute:
$ sensors "k10temp-*"
k10temp-pci-00c3
Adapter: PCI adapter
Vcore: 1.29 V
Vsoc: 1.01 V
Tdie: +77.1°C (high = +70.0°C)
Tctl: +77.1°C
Tccd1: +78.8°C
Icore: 39.53 A
Isoc: 6.18 A
Board Information during the idle check:
$ sudo dmidecode -s system-manufacturer
Gigabyte Technology Co., Ltd.
$ sudo dmidecode -s system-product-name
X570 AORUS ULTRA
$ sensors "it8792-*"
it8792-isa-0a60
Adapter: ISA adapter
in0: 1.79 V (min = +0.00 V, max = +2.78 V)
in1: 589.00 mV (min = +0.00 V, max = +2.78 V)
in2: 981.00 mV (min = +0.00 V, max = +2.78 V)
+3.3V: 1.68 V (min = +0.00 V, max = +2.78 V)
in4: 1.79 V (min = +0.00 V, max = +2.78 V)
in5: 1.18 V (min = +0.00 V, max = +2.78 V)
in6: 2.78 V (min = +0.00 V, max = +2.78 V) ALARM
3VSB: 1.68 V (min = +0.00 V, max = +2.78 V)
Vbat: 1.61 V
fan1: 0 RPM (min = 0 RPM)
fan2: 0 RPM (min = 0 RPM)
fan3: 0 RPM (min = 0 RPM)
temp1: +37.0°C (low = +127.0°C, high = +127.0°C) sensor = thermistor
temp3: +36.0°C (low = +127.0°C, high = +127.0°C) sensor = thermistor
intrusion0: ALARM
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-17 19:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 14:17 [RFT PATCH 0/4] hwmon: k10temp driver improvements Guenter Roeck
2020-01-16 14:17 ` [RFT PATCH 1/4] hwmon: (k10temp) Use bitops Guenter Roeck
2020-01-16 14:17 ` [RFT PATCH 2/4] hmon: (k10temp) Convert to use devm_hwmon_device_register_with_info Guenter Roeck
2020-01-16 14:17 ` [RFT PATCH 3/4] hwmon: (k10temp) Report temperatures per CPU die Guenter Roeck
2020-01-16 14:18 ` [RFT PATCH 4/4] hwmon: (k10temp) Show core and SoC current and voltages on Zen CPUs Guenter Roeck
2020-01-16 20:55 ` [RFT PATCH 0/4] hwmon: k10temp driver improvements Darren Salt
2020-01-16 21:11 ` Guenter Roeck
2020-01-16 22:46 ` Bernhard Gebetsberger
2020-01-16 22:52 ` Guenter Roeck
2020-01-17 0:38 ` Ken Moffat
2020-01-17 3:58 ` Guenter Roeck
2020-01-17 4:47 ` Ken Moffat
2020-01-17 14:14 ` Guenter Roeck
2020-01-17 18:58 ` Ken Moffat
2020-01-17 9:46 ` Ondrej Čerman
2020-01-17 18:46 ` Guenter Roeck
2020-01-17 22:48 ` Ondrej Čerman
2020-01-17 9:58 ` Holger Kiehl
2020-01-17 19:15 ` Sebastian Reichel [this message]
2020-01-18 8:52 ` Brad Campbell
2020-01-18 17:14 ` Guenter Roeck
2020-01-19 1:59 ` Brad Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117191517.pp4vqzkectju4mnd@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=clemens@ladisch.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).