linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Logan Shaw <logan.shaw@alliedtelesis.co.nz>
Cc: linux@roeck-us.net, jdelvare@suse.com, robh+dt@kernel.org,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Joshua.Scott@alliedtelesis.co.nz,
	Chris.Packham@alliedtelesis.co.nz,
	logan.shaw@alliedtelesis.co.nz
Subject: Re: [PATCH v4 2/2] hwmon: (adt7475) Added attenuator bypass support
Date: Tue, 21 Jan 2020 12:00:29 -0600	[thread overview]
Message-ID: <20200121180029.GA32498@bogus> (raw)
In-Reply-To: <20200120001703.9927-3-logan.shaw@alliedtelesis.co.nz>

On Mon, 20 Jan 2020 13:17:03 +1300, Logan Shaw wrote:
> 
> Added a new file documenting the adt7475 devicetree and added the four
> new properties to it.
> 
> Signed-off-by: Logan Shaw <logan.shaw@alliedtelesis.co.nz>
> ---
> ---
>  .../devicetree/bindings/hwmon/adt7475.yaml    | 90 +++++++++++++++++++
>  1 file changed, 90 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adt7475.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/hwmon/adt7475.example.dts:19.11-24: Warning (reg_format): /example-0/hwmon@2e:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/hwmon/adt7475.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/hwmon/adt7475.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/hwmon/adt7475.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'

See https://patchwork.ozlabs.org/patch/1225573
Please check and re-submit.

  reply	other threads:[~2020-01-21 18:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20  0:17 [PATCH v4 0/2] hwmon: (adt7475) Added attenuator bypass support Logan Shaw
2020-01-20  0:17 ` [PATCH v4 1/2] " Logan Shaw
2020-01-22 15:03   ` Guenter Roeck
2020-01-20  0:17 ` [PATCH v4 2/2] " Logan Shaw
2020-01-21 18:00   ` Rob Herring [this message]
2020-01-22 14:47   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200121180029.GA32498@bogus \
    --to=robh@kernel.org \
    --cc=Chris.Packham@alliedtelesis.co.nz \
    --cc=Joshua.Scott@alliedtelesis.co.nz \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=logan.shaw@alliedtelesis.co.nz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).