Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list
@ 2020-01-29 15:08 Haochen Tong
  2020-01-29 15:08 ` [PATCH 1/2] dell-smm-hwmon: add " Haochen Tong
  2020-01-29 15:08 ` [PATCH 2/2] dell-smm-hwmon: add XPS 13 9360 to fan control whitelist Haochen Tong
  0 siblings, 2 replies; 5+ messages in thread
From: Haochen Tong @ 2020-01-29 15:08 UTC (permalink / raw)
  To: pali.rohar, linux-hwmon; +Cc: jdelvare, linux, Haochen Tong

This patch adds Dell XPS 13 9360 to supported devices list in
dell-smm-hwmon.

I have tested this on one such device and verified that the fan speed is
correctly reported, and can be controlled through pwm1{,_enable}.

Haochen Tong (2):
  dell-smm-hwmon: add XPS 13 9360 to supported devices list
  dell-smm-hwmon: add XPS 13 9360 to fan control whitelist

 drivers/hwmon/dell-smm-hwmon.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)


base-commit: b3a6082223369203d7e7db7e81253ac761377644
-- 
2.25.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] dell-smm-hwmon: add XPS 13 9360 to supported devices list
  2020-01-29 15:08 [PATCH 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list Haochen Tong
@ 2020-01-29 15:08 ` " Haochen Tong
  2020-01-30 22:10   ` Pali Rohár
  2020-01-29 15:08 ` [PATCH 2/2] dell-smm-hwmon: add XPS 13 9360 to fan control whitelist Haochen Tong
  1 sibling, 1 reply; 5+ messages in thread
From: Haochen Tong @ 2020-01-29 15:08 UTC (permalink / raw)
  To: pali.rohar, linux-hwmon; +Cc: jdelvare, linux, Haochen Tong

Tests have shown that this module works fine on XPS 13 9360: it can
successfully detect and report fan status.

Signed-off-by: Haochen Tong <i@hexchain.org>
---
 drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 17583bf8c2dc..d9f6394c08d6 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1104,6 +1104,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_config_data[DELL_XPS],
 	},
+	{
+		.ident = "Dell XPS 13 9360",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
+		},
+	},
 	{
 		.ident = "Dell XPS 15 9560",
 		.matches = {
-- 
2.25.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] dell-smm-hwmon: add XPS 13 9360 to fan control whitelist
  2020-01-29 15:08 [PATCH 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list Haochen Tong
  2020-01-29 15:08 ` [PATCH 1/2] dell-smm-hwmon: add " Haochen Tong
@ 2020-01-29 15:08 ` Haochen Tong
  1 sibling, 0 replies; 5+ messages in thread
From: Haochen Tong @ 2020-01-29 15:08 UTC (permalink / raw)
  To: pali.rohar, linux-hwmon; +Cc: jdelvare, linux, Haochen Tong

Tests have shown that fan control works fine on XPS 13 9360.

Signed-off-by: Haochen Tong <i@hexchain.org>
---
 drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index d9f6394c08d6..f20a7ea050e1 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1225,6 +1225,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = {
 		},
 		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
 	},
+	{
+		.ident = "Dell XPS 13 9360",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
+		},
+		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+	},
 	{ }
 };
 
-- 
2.25.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dell-smm-hwmon: add XPS 13 9360 to supported devices list
  2020-01-29 15:08 ` [PATCH 1/2] dell-smm-hwmon: add " Haochen Tong
@ 2020-01-30 22:10   ` Pali Rohár
  2020-01-31 20:36     ` Haochen Tong
  0 siblings, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2020-01-30 22:10 UTC (permalink / raw)
  To: Haochen Tong; +Cc: linux-hwmon, jdelvare, linux

On Wednesday 29 January 2020 16:08:38 Haochen Tong wrote:
> Tests have shown that this module works fine on XPS 13 9360: it can
> successfully detect and report fan status.
> 
> Signed-off-by: Haochen Tong <i@hexchain.org>
> ---
>  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 17583bf8c2dc..d9f6394c08d6 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1104,6 +1104,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
>  		},
>  		.driver_data = (void *)&i8k_config_data[DELL_XPS],
>  	},
> +	{
> +		.ident = "Dell XPS 13 9360",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),

Hello! In patch 2/2 you are using DMI_EXACT_MATCH. I think it does not
make sense to use substring match in one case and exact match in another
case for one specific machine. I would suggest to use one type of match
for both cases.

> +		},
> +	},
>  	{
>  		.ident = "Dell XPS 15 9560",
>  		.matches = {

-- 
Pali Rohár
pali.rohar@gmail.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dell-smm-hwmon: add XPS 13 9360 to supported devices list
  2020-01-30 22:10   ` Pali Rohár
@ 2020-01-31 20:36     ` Haochen Tong
  0 siblings, 0 replies; 5+ messages in thread
From: Haochen Tong @ 2020-01-31 20:36 UTC (permalink / raw)
  To: Pali Rohár; +Cc: linux-hwmon, jdelvare, linux

On Thu, Jan 30, 2020 at 11:10:11PM +0100, Pali Rohár wrote:
> On Wednesday 29 January 2020 16:08:38 Haochen Tong wrote:
> > Tests have shown that this module works fine on XPS 13 9360: it can
> > successfully detect and report fan status.
> > 
> > Signed-off-by: Haochen Tong <i@hexchain.org>
> > ---
> >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > index 17583bf8c2dc..d9f6394c08d6 100644
> > --- a/drivers/hwmon/dell-smm-hwmon.c
> > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > @@ -1104,6 +1104,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
> >  		},
> >  		.driver_data = (void *)&i8k_config_data[DELL_XPS],
> >  	},
> > +	{
> > +		.ident = "Dell XPS 13 9360",
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
> 
> Hello! In patch 2/2 you are using DMI_EXACT_MATCH. I think it does not
> make sense to use substring match in one case and exact match in another
> case for one specific machine. I would suggest to use one type of match
> for both cases.
> 

Sure, will fix.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 15:08 [PATCH 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list Haochen Tong
2020-01-29 15:08 ` [PATCH 1/2] dell-smm-hwmon: add " Haochen Tong
2020-01-30 22:10   ` Pali Rohár
2020-01-31 20:36     ` Haochen Tong
2020-01-29 15:08 ` [PATCH 2/2] dell-smm-hwmon: add XPS 13 9360 to fan control whitelist Haochen Tong

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git