* [PATCH v2 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list
@ 2020-02-02 23:31 Haochen Tong
2020-02-02 23:31 ` [PATCH v2 1/2] dell-smm-hwmon: add " Haochen Tong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Haochen Tong @ 2020-02-02 23:31 UTC (permalink / raw)
To: pali.rohar, linux-hwmon; +Cc: jdelvare, linux, Haochen Tong
This patch adds Dell XPS 13 9360 to supported devices list in
dell-smm-hwmon.
I have tested this on one such device and verified that the fan speed is
correctly reported, and can be controlled through pwm1{,_enable}.
Haochen Tong (2):
dell-smm-hwmon: add XPS 13 9360 to supported devices list
dell-smm-hwmon: add XPS 13 9360 to fan control whitelist
drivers/hwmon/dell-smm-hwmon.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
base-commit: 46d6b7becb1d5a8e697db786590c19e4067a975a
--
2.25.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/2] dell-smm-hwmon: add XPS 13 9360 to supported devices list
2020-02-02 23:31 [PATCH v2 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list Haochen Tong
@ 2020-02-02 23:31 ` Haochen Tong
2020-02-02 23:31 ` [PATCH v2 2/2] dell-smm-hwmon: add XPS 13 9360 to fan control whitelist Haochen Tong
2020-02-04 8:06 ` [PATCH v2 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list Pali Rohár
2 siblings, 0 replies; 4+ messages in thread
From: Haochen Tong @ 2020-02-02 23:31 UTC (permalink / raw)
To: pali.rohar, linux-hwmon; +Cc: jdelvare, linux, Haochen Tong
Tests have shown that this module works fine on XPS 13 9360: it can
successfully detect and report fan status.
Signed-off-by: Haochen Tong <i@hexchain.org>
---
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 17583bf8c2dc..c8f2182ba969 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1118,6 +1118,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9570"),
},
},
+ {
+ .ident = "Dell XPS 13 9360",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
+ },
+ },
{ }
};
--
2.25.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] dell-smm-hwmon: add XPS 13 9360 to fan control whitelist
2020-02-02 23:31 [PATCH v2 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list Haochen Tong
2020-02-02 23:31 ` [PATCH v2 1/2] dell-smm-hwmon: add " Haochen Tong
@ 2020-02-02 23:31 ` Haochen Tong
2020-02-04 8:06 ` [PATCH v2 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list Pali Rohár
2 siblings, 0 replies; 4+ messages in thread
From: Haochen Tong @ 2020-02-02 23:31 UTC (permalink / raw)
To: pali.rohar, linux-hwmon; +Cc: jdelvare, linux, Haochen Tong
Tests have shown that fan control works fine on XPS 13 9360.
Signed-off-by: Haochen Tong <i@hexchain.org>
---
drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index c8f2182ba969..f79e10a55840 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1225,6 +1225,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = {
},
.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
},
+ {
+ .ident = "Dell XPS 13 9360",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
+ },
+ .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+ },
{ }
};
--
2.25.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list
2020-02-02 23:31 [PATCH v2 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list Haochen Tong
2020-02-02 23:31 ` [PATCH v2 1/2] dell-smm-hwmon: add " Haochen Tong
2020-02-02 23:31 ` [PATCH v2 2/2] dell-smm-hwmon: add XPS 13 9360 to fan control whitelist Haochen Tong
@ 2020-02-04 8:06 ` Pali Rohár
2 siblings, 0 replies; 4+ messages in thread
From: Pali Rohár @ 2020-02-04 8:06 UTC (permalink / raw)
To: Haochen Tong; +Cc: linux-hwmon, jdelvare, linux
On Monday 03 February 2020 00:31:49 Haochen Tong wrote:
> This patch adds Dell XPS 13 9360 to supported devices list in
> dell-smm-hwmon.
>
> I have tested this on one such device and verified that the fan speed is
> correctly reported, and can be controlled through pwm1{,_enable}.
>
> Haochen Tong (2):
> dell-smm-hwmon: add XPS 13 9360 to supported devices list
> dell-smm-hwmon: add XPS 13 9360 to fan control whitelist
>
> drivers/hwmon/dell-smm-hwmon.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
>
> base-commit: 46d6b7becb1d5a8e697db786590c19e4067a975a
Hello, both patches now look good, you can add my:
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-04 8:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-02 23:31 [PATCH v2 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list Haochen Tong
2020-02-02 23:31 ` [PATCH v2 1/2] dell-smm-hwmon: add " Haochen Tong
2020-02-02 23:31 ` [PATCH v2 2/2] dell-smm-hwmon: add XPS 13 9360 to fan control whitelist Haochen Tong
2020-02-04 8:06 ` [PATCH v2 0/2] dell-smm-hwmon: Add XPS 13 9360 to supported devices list Pali Rohár
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).