Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Colin King <colin.king@canonical.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
	"Jean Delvare" <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] hwmon: axi-fan-control: fix uninitialized dereference of pointer res
Date: Tue, 11 Feb 2020 08:39:10 -0800
Message-ID: <20200211163910.GA2975@roeck-us.net> (raw)
In-Reply-To: <20200211162059.94233-1-colin.king@canonical.com>

On Tue, Feb 11, 2020 at 04:20:59PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently the resource pointer ret is uninitialized and it is
> being dereferenced when printing out a debug message. Fix this
> by fetching the resource and assigning pointer res.  It is
> a moot point that we sanity check for a null res since a successful
> call to devm_platform_ioremap_resource has already occurred so
> in theory it should never be non-null.
> 
> Addresses-Coverity: ("Uninitialized pointer read")
> Fixes: 690dd9ce04f6 ("hwmon: Support ADI Fan Control IP")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This has already been fixed by removing the message (and the
then unused variable). The message was useless anyway since
it printed the remapped address with %p.

Guenter

> ---
>  drivers/hwmon/axi-fan-control.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c
> index 8041ba7cc152..36e0d060510a 100644
> --- a/drivers/hwmon/axi-fan-control.c
> +++ b/drivers/hwmon/axi-fan-control.c
> @@ -415,6 +415,9 @@ static int axi_fan_control_probe(struct platform_device *pdev)
>  	if (!ctl->clk_rate)
>  		return -EINVAL;
>  
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res)
> +		return -EINVAL;
>  	dev_dbg(&pdev->dev, "Re-mapped from 0x%08llX to %p\n",
>  		(unsigned long long)res->start, ctl->base);
>  
> -- 
> 2.25.0
> 

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 16:20 Colin King
2020-02-11 16:39 ` Guenter Roeck [this message]
2020-02-11 16:41   ` Colin Ian King

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211163910.GA2975@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=colin.king@canonical.com \
    --cc=jdelvare@suse.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git