From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=IX/m=4J=vger.kernel.org=linux-hwmon-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,
	SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT
	autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1D7ECC11D28
	for <linux-hwmon@archiver.kernel.org>; Fri, 21 Feb 2020 04:17:03 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E876220722
	for <linux-hwmon@archiver.kernel.org>; Fri, 21 Feb 2020 04:17:02 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="jR/pmPxd"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729718AbgBUEQr (ORCPT <rfc822;linux-hwmon@archiver.kernel.org>);
        Thu, 20 Feb 2020 23:16:47 -0500
Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:58154 "EHLO
        gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729615AbgBUEQq (ORCPT
        <rfc822;linux-hwmon@vger.kernel.org>);
        Thu, 20 Feb 2020 23:16:46 -0500
Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (Client did not present a certificate)
        by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 3B4EE891AB;
        Fri, 21 Feb 2020 17:16:44 +1300 (NZDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz;
        s=mail181024; t=1582258604;
        bh=RwLHepCx03CNEZvF3kbx50mD0JOEcmY6pn/SjTogwSg=;
        h=From:To:Cc:Subject:Date:In-Reply-To:References;
        b=jR/pmPxdWw38ncgsejH7KkxLbNfeEt8pCw1DgbTuET8+Uuk9YGsOPxykPk2QzYiVu
         POQZBqWT/DgyTOM2Y+Z9PHov6EuQrUMfPYvgTytH8au24H1ZHiN+EaEzHlc94YuUd5
         zjjqeKJOWP5QPRh77uIfl3JvrDmL/5DSBvWC+gC3z0YnQjAz4b0lHtCM85cl3pnvMO
         LJnokr4OaYK0iTtCU4vEyPRRJz2sH44brrtoYJTsrfwHya9ok+eoElwXaSSbOQ2lMn
         6iILQifkIfUMFwxFTrVNONEK9ffKdQDJqL5RNCLDjofcbG7OASI4bk+d0CANs6bDjb
         ejEKo+Cwb6Obg==
Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7,5,8,10121)
        id <B5e4f59ac0004>; Fri, 21 Feb 2020 17:16:44 +1300
Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.20])
        by smtp (Postfix) with ESMTP id 7BFB813EECD;
        Fri, 21 Feb 2020 17:16:43 +1300 (NZDT)
Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030)
        id 1001028006D; Fri, 21 Feb 2020 17:16:44 +1300 (NZDT)
From:   Chris Packham <chris.packham@alliedtelesis.co.nz>
To:     jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
        mark.rutland@arm.com
Cc:     linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, logan.shaw@alliedtelesis.co.nz,
        Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v4 5/5] hwmon: (adt7475) Add support for inverting pwm output
Date:   Fri, 21 Feb 2020 17:16:31 +1300
Message-Id: <20200221041631.10960-6-chris.packham@alliedtelesis.co.nz>
X-Mailer: git-send-email 2.25.0
In-Reply-To: <20200221041631.10960-1-chris.packham@alliedtelesis.co.nz>
References: <20200221041631.10960-1-chris.packham@alliedtelesis.co.nz>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
x-atlnz-ls: pat
Sender: linux-hwmon-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-hwmon.vger.kernel.org>
X-Mailing-List: linux-hwmon@vger.kernel.org

Add a "invert-pwm" device-tree property to allow hardware designs to use
inverted logic on the PWM output. Preserve the invert PWM output bit if
the property is not found to allow for bootloaders/bios which may have
configured this earlier.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---

Notes:
    Changes in v4:
    - use vendor prefix for new property
   =20
    Changes in v3:
    - New

 drivers/hwmon/adt7475.c | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 3649b18359dc..13267181dde6 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -1509,6 +1509,41 @@ static int load_attenuators(const struct i2c_clien=
t *client, int chip,
 	return 0;
 }
=20
+static int adt7475_set_pwm_polarity(struct i2c_client *client)
+{
+	char *prop;
+	int ret, i;
+	u8 val;
+
+	for (i =3D 0; i < ADT7475_PWM_COUNT; i++) {
+		ret =3D adt7475_read(PWM_CONFIG_REG(i));
+		if (ret < 0)
+			return ret;
+		val =3D ret;
+		switch (i) {
+		case 0:
+			prop =3D "adi,invert-pwm1";
+			break;
+		case 1:
+			prop =3D "adi,invert-pwm2";
+			break;
+		case 2:
+			prop =3D "adi,invert-pwm3";
+			break;
+		}
+
+		ret =3D set_property_bit(client, prop, &val, 4);
+		if (ret)
+			continue;
+
+		ret =3D i2c_smbus_write_byte_data(client, PWM_CONFIG_REG(i), val);
+		if (ret)
+			return ret;
+	}
+
+	return 0;
+}
+
 static int adt7475_probe(struct i2c_client *client,
 			 const struct i2c_device_id *id)
 {
@@ -1617,6 +1652,10 @@ static int adt7475_probe(struct i2c_client *client=
,
 	for (i =3D 0; i < ADT7475_PWM_COUNT; i++)
 		adt7475_read_pwm(client, i);
=20
+	ret =3D adt7475_set_pwm_polarity(client);
+	if (ret)
+		dev_err(&client->dev, "Error configuring pwm polarity");
+
 	/* Start monitoring */
 	switch (chip) {
 	case adt7475:
--=20
2.25.0