Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on hwmon/hwmon-next] [also build test ERROR on next-20200324] [cannot apply to v5.6-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/yuechao-zhao-advantech-com-cn/hwmon-nct7904-Add-watchdog-function/20200324-095738 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: h8300-randconfig-a001-20200324 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=h8300 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): h8300-linux-ld: drivers/hwmon/nct7904.o: in function `nct7904_remove': drivers/hwmon/nct7904.c:1165: undefined reference to `watchdog_unregister_device' h8300-linux-ld: drivers/hwmon/nct7904.o: in function `nct7904_probe': drivers/hwmon/nct7904.c:1138: undefined reference to `watchdog_init_timeout' >> h8300-linux-ld: drivers/hwmon/nct7904.c:1144: undefined reference to `watchdog_register_device' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org