From: Guenter Roeck <linux@roeck-us.net>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH] hwmon: (jc42) Fix name to have no illegal characters
Date: Sat, 18 Apr 2020 10:13:34 -0700 [thread overview]
Message-ID: <20200418171334.GA51539@roeck-us.net> (raw)
In-Reply-To: <20200417092853.31206-1-s.hauer@pengutronix.de>
On Fri, Apr 17, 2020 at 11:28:53AM +0200, Sascha Hauer wrote:
> The jc42 driver passes I2C client's name as hwmon device name. In case
> of device tree probed devices this ends up being part of the compatible
> string, "jc-42.4-temp". This name contains hyphens and the hwmon core
> doesn't like this:
>
> jc42 2-0018: hwmon: 'jc-42.4-temp' is not a valid name attribute, please fix
>
> This changes the name to "jc42" which doesn't have any illegal
> characters.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
I have not heard a better suggestion, so applied.
Thanks,
Guenter
> ---
> drivers/hwmon/jc42.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> index f2d81b0558e5..e3f1ebee7130 100644
> --- a/drivers/hwmon/jc42.c
> +++ b/drivers/hwmon/jc42.c
> @@ -506,7 +506,7 @@ static int jc42_probe(struct i2c_client *client, const struct i2c_device_id *id)
> }
> data->config = config;
>
> - hwmon_dev = devm_hwmon_device_register_with_info(dev, client->name,
> + hwmon_dev = devm_hwmon_device_register_with_info(dev, "jc42",
> data, &jc42_chip_info,
> NULL);
> return PTR_ERR_OR_ZERO(hwmon_dev);
prev parent reply other threads:[~2020-04-18 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 9:28 [PATCH] hwmon: (jc42) Fix name to have no illegal characters Sascha Hauer
2020-04-17 9:55 ` Jean Delvare
2020-04-17 10:32 ` Sascha Hauer
2020-04-17 13:47 ` Jean Delvare
2020-04-18 3:19 ` Guenter Roeck
2020-04-18 3:14 ` Guenter Roeck
2020-04-18 17:13 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418171334.GA51539@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).