* [PATCH 0/3] hwmon: Adding support for Microchip Sparx5 SoC
@ 2020-05-13 13:41 Lars Povlsen
2020-05-13 13:41 ` [PATCH 1/3] dt-bindings: hwmon: Add Sparx5 temperature sensor Lars Povlsen
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Lars Povlsen @ 2020-05-13 13:41 UTC (permalink / raw)
To: Guenter Roeck, SoC Team
Cc: Lars Povlsen, Jean Delvare, Microchip Linux Driver Support,
linux-hwmon, devicetree, linux-arm-kernel, linux-kernel
This is an add-on series to the main SoC Sparx5 series
(Message-ID: <20200513125532.24585-1-lars.povlsen@microchip.com>).
It is expected that the DT patches are to be taken directly by the arm-soc
maintainers.
Lars Povlsen (3):
dt-bindings: hwmon: Add Sparx5 temperature sensor
arm64: dts: sparx5: Add hwmon temperature sensor
hwmon: sparx5: Add Sparx5 SoC temperature driver
.../bindings/hwmon/microchip,sparx5-temp.yaml | 39 +++++
arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 +
drivers/hwmon/Kconfig | 10 ++
drivers/hwmon/Makefile | 2 +-
drivers/hwmon/sparx5-temp.c | 154 ++++++++++++++++++
5 files changed, 210 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
create mode 100644 drivers/hwmon/sparx5-temp.c
--
2.26.2
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/3] dt-bindings: hwmon: Add Sparx5 temperature sensor 2020-05-13 13:41 [PATCH 0/3] hwmon: Adding support for Microchip Sparx5 SoC Lars Povlsen @ 2020-05-13 13:41 ` Lars Povlsen 2020-05-13 13:41 ` [PATCH 2/3] arm64: dts: sparx5: Add hwmon " Lars Povlsen 2020-05-13 13:41 ` [PATCH 3/3] hwmon: sparx5: Add Sparx5 SoC temperature driver Lars Povlsen 2 siblings, 0 replies; 8+ messages in thread From: Lars Povlsen @ 2020-05-13 13:41 UTC (permalink / raw) To: Guenter Roeck, SoC Team, Rob Herring Cc: Lars Povlsen, Jean Delvare, Microchip Linux Driver Support, linux-hwmon, devicetree, linux-arm-kernel, linux-kernel, Alexandre Belloni This add the DT binding specification for the Sparx5 temperature sensor. Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com> --- .../bindings/hwmon/microchip,sparx5-temp.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml diff --git a/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml b/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml new file mode 100644 index 0000000000000..0df4813fd7b24 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/microchip,sparx5-temp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip Sparx5 Temperature Monitor + +maintainers: + - Lars Povlsen <lars.povlsen@microchip.com> + +description: | + Microchip Sparx5 embedded temperature monitor + +properties: + compatible: + enum: + - microchip,sparx5-temp + + reg: + maxItems: 1 + + '#thermal-sensor-cells': + const: 0 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + tmon0: tmon@610508110 { + compatible = "microchip,sparx5-temp"; + reg = <0x10508110 0xc>; + #thermal-sensor-cells = <0>; + }; + -- 2.26.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] arm64: dts: sparx5: Add hwmon temperature sensor 2020-05-13 13:41 [PATCH 0/3] hwmon: Adding support for Microchip Sparx5 SoC Lars Povlsen 2020-05-13 13:41 ` [PATCH 1/3] dt-bindings: hwmon: Add Sparx5 temperature sensor Lars Povlsen @ 2020-05-13 13:41 ` Lars Povlsen 2020-05-28 2:29 ` Rob Herring 2020-05-13 13:41 ` [PATCH 3/3] hwmon: sparx5: Add Sparx5 SoC temperature driver Lars Povlsen 2 siblings, 1 reply; 8+ messages in thread From: Lars Povlsen @ 2020-05-13 13:41 UTC (permalink / raw) To: Guenter Roeck, SoC Team Cc: Lars Povlsen, Jean Delvare, Microchip Linux Driver Support, linux-hwmon, devicetree, linux-arm-kernel, linux-kernel, Alexandre Belloni This adds a hwmon temperature node sensor to the Sparx5 SoC. Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com> --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi index f09a49c41ce19..b5f2d088af30e 100644 --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi @@ -233,5 +233,11 @@ i2c1: i2c@600103000 { clock-frequency = <100000>; clocks = <&ahb_clk>; }; + + tmon0: tmon@610508110 { + compatible = "microchip,sparx5-temp"; + reg = <0x6 0x10508110 0xc>; + #thermal-sensor-cells = <0>; + }; }; }; -- 2.26.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] arm64: dts: sparx5: Add hwmon temperature sensor 2020-05-13 13:41 ` [PATCH 2/3] arm64: dts: sparx5: Add hwmon " Lars Povlsen @ 2020-05-28 2:29 ` Rob Herring 2020-05-28 3:39 ` Alexandre Belloni 0 siblings, 1 reply; 8+ messages in thread From: Rob Herring @ 2020-05-28 2:29 UTC (permalink / raw) To: Lars Povlsen Cc: Guenter Roeck, SoC Team, Jean Delvare, Microchip Linux Driver Support, linux-hwmon, devicetree, linux-arm-kernel, linux-kernel, Alexandre Belloni On Wed, May 13, 2020 at 03:41:39PM +0200, Lars Povlsen wrote: > This adds a hwmon temperature node sensor to the Sparx5 SoC. > > Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com> > --- > arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi > index f09a49c41ce19..b5f2d088af30e 100644 > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > @@ -233,5 +233,11 @@ i2c1: i2c@600103000 { > clock-frequency = <100000>; > clocks = <&ahb_clk>; > }; > + > + tmon0: tmon@610508110 { > + compatible = "microchip,sparx5-temp"; > + reg = <0x6 0x10508110 0xc>; These nodes are all very odd with a couple of registers spread out at randomish addresses. DT nodes should roughly correlate to h/w blocks, not sets of registers for a driver like this seems to be. Please make the dts files one patch. Reviewing a node at a time is not all that effective. Rob ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] arm64: dts: sparx5: Add hwmon temperature sensor 2020-05-28 2:29 ` Rob Herring @ 2020-05-28 3:39 ` Alexandre Belloni 0 siblings, 0 replies; 8+ messages in thread From: Alexandre Belloni @ 2020-05-28 3:39 UTC (permalink / raw) To: Rob Herring Cc: Lars Povlsen, Guenter Roeck, SoC Team, Jean Delvare, Microchip Linux Driver Support, linux-hwmon, devicetree, linux-arm-kernel, linux-kernel Hi Rob, On 27/05/2020 20:29:31-0600, Rob Herring wrote: > On Wed, May 13, 2020 at 03:41:39PM +0200, Lars Povlsen wrote: > > This adds a hwmon temperature node sensor to the Sparx5 SoC. > > > > Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com> > > --- > > arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > index f09a49c41ce19..b5f2d088af30e 100644 > > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > @@ -233,5 +233,11 @@ i2c1: i2c@600103000 { > > clock-frequency = <100000>; > > clocks = <&ahb_clk>; > > }; > > + > > + tmon0: tmon@610508110 { > > + compatible = "microchip,sparx5-temp"; > > + reg = <0x6 0x10508110 0xc>; > > These nodes are all very odd with a couple of registers spread out at > randomish addresses. DT nodes should roughly correlate to h/w blocks, > not sets of registers for a driver like this seems to be. > The DT nodes correlates to HW block, this and the previous families of SoCs were designed with packed registers. There is no padding between HW block registers. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] hwmon: sparx5: Add Sparx5 SoC temperature driver 2020-05-13 13:41 [PATCH 0/3] hwmon: Adding support for Microchip Sparx5 SoC Lars Povlsen 2020-05-13 13:41 ` [PATCH 1/3] dt-bindings: hwmon: Add Sparx5 temperature sensor Lars Povlsen 2020-05-13 13:41 ` [PATCH 2/3] arm64: dts: sparx5: Add hwmon " Lars Povlsen @ 2020-05-13 13:41 ` Lars Povlsen 2020-05-13 15:20 ` Guenter Roeck 2 siblings, 1 reply; 8+ messages in thread From: Lars Povlsen @ 2020-05-13 13:41 UTC (permalink / raw) To: Guenter Roeck, SoC Team Cc: Lars Povlsen, Jean Delvare, Microchip Linux Driver Support, linux-hwmon, devicetree, linux-arm-kernel, linux-kernel, Alexandre Belloni This patch adds a temperature sensor driver to the Sparx5 SoC. Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com> --- drivers/hwmon/Kconfig | 10 +++ drivers/hwmon/Makefile | 2 +- drivers/hwmon/sparx5-temp.c | 154 ++++++++++++++++++++++++++++++++++++ 3 files changed, 165 insertions(+), 1 deletion(-) create mode 100644 drivers/hwmon/sparx5-temp.c diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index 4c62f900bf7e8..130cb1f1748ff 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -480,6 +480,16 @@ config SENSORS_I5K_AMB This driver can also be built as a module. If so, the module will be called i5k_amb. +config SENSORS_SPARX5 + tristate "Sparx5 SoC temperature sensor" + depends on ARCH_SPARX5 + help + If you say yes here you get support for temperature monitoring + with the Microchip Sparx5 SoC. + + This driver can also be built as a module. If so, the module + will be called sparx5-temp. + config SENSORS_F71805F tristate "Fintek F71805F/FG, F71806F/FG and F71872F/FG" depends on !PPC diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile index b0b9c8e571762..28a09986b7a62 100644 --- a/drivers/hwmon/Makefile +++ b/drivers/hwmon/Makefile @@ -64,6 +64,7 @@ obj-$(CONFIG_SENSORS_DS1621) += ds1621.o obj-$(CONFIG_SENSORS_EMC1403) += emc1403.o obj-$(CONFIG_SENSORS_EMC2103) += emc2103.o obj-$(CONFIG_SENSORS_EMC6W201) += emc6w201.o +obj-$(CONFIG_SENSORS_SPARX5) += sparx5-temp.o obj-$(CONFIG_SENSORS_F71805F) += f71805f.o obj-$(CONFIG_SENSORS_F71882FG) += f71882fg.o obj-$(CONFIG_SENSORS_F75375S) += f75375s.o @@ -190,4 +191,3 @@ obj-$(CONFIG_SENSORS_OCC) += occ/ obj-$(CONFIG_PMBUS) += pmbus/ ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG - diff --git a/drivers/hwmon/sparx5-temp.c b/drivers/hwmon/sparx5-temp.c new file mode 100644 index 0000000000000..bf9dd102a9825 --- /dev/null +++ b/drivers/hwmon/sparx5-temp.c @@ -0,0 +1,154 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* Sparx5 SoC temperature sensor driver + * + * Copyright (C) 2020 Lars Povlsen <lars.povlsen@microchip.com> + */ + +#include <linux/bitops.h> +#include <linux/hwmon.h> +#include <linux/hwmon-sysfs.h> +#include <linux/init.h> +#include <linux/io.h> +#include <linux/module.h> +#include <linux/of_device.h> + +#define TEMP_CTRL 0 +#define TEMP_CFG 4 +#define TEMP_CFG_CYCLES GENMASK(24, 15) +#define TEMP_CFG_CYCLES_OFF 15 +#define TEMP_CFG_ENA BIT(0) +#define TEMP_STAT 8 +#define TEMP_STAT_VALID BIT(12) +#define TEMP_STAT_TEMP GENMASK(11, 0) + +struct s5_hwmon { + void __iomem *base; +}; + +static void s5_temp_enable(struct s5_hwmon *hwmon) +{ + u32 val = readl(hwmon->base + TEMP_CFG); + u32 clk = 250; + + val &= ~TEMP_CFG_CYCLES; + val |= (clk << TEMP_CFG_CYCLES_OFF); + val |= TEMP_CFG_ENA; + + writel(val, hwmon->base + TEMP_CFG); +} + +static void s5_temp_disable(void *data) +{ + struct s5_hwmon *hwmon = data; + u32 val = readl(hwmon->base + TEMP_CFG); + + val &= ~TEMP_CFG_ENA; + + writel(val, hwmon->base + TEMP_CFG); +} + +static int s5_read(struct device *dev, enum hwmon_sensor_types type, + u32 attr, int channel, long *temp) +{ + struct s5_hwmon *hwmon = dev_get_drvdata(dev); + int rc = 0, value; + u32 stat; + + switch (attr) { + case hwmon_temp_input: + stat = readl_relaxed(hwmon->base + TEMP_STAT); + if (stat & TEMP_STAT_VALID) { + value = (stat & TEMP_STAT_TEMP); + value = DIV_ROUND_CLOSEST(value * 3522, 4096) - 1094; + value *= 100; + *temp = value; + } else + rc = -EINVAL; + break; + default: + rc = -EOPNOTSUPP; + } + + return rc; +} + +static umode_t s5_is_visible(const void *_data, enum hwmon_sensor_types type, + u32 attr, int channel) +{ + if (type != hwmon_temp) + return 0; + + switch (attr) { + case hwmon_temp_input: + return 0444; + default: + return 0; + } +} + +static const struct hwmon_channel_info *s5_info[] = { + HWMON_CHANNEL_INFO(chip, + HWMON_C_REGISTER_TZ), + HWMON_CHANNEL_INFO(temp, + HWMON_T_INPUT), + NULL +}; + +static const struct hwmon_ops s5_hwmon_ops = { + .is_visible = s5_is_visible, + .read = s5_read, +}; + +static const struct hwmon_chip_info s5_chip_info = { + .ops = &s5_hwmon_ops, + .info = s5_info, +}; + +static int s5_temp_probe(struct platform_device *pdev) +{ + struct device *hwmon_dev; + struct s5_hwmon *hwmon; + int err = 0; + + hwmon = devm_kzalloc(&pdev->dev, sizeof(*hwmon), GFP_KERNEL); + if (!hwmon) + return -ENOMEM; + + hwmon->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(hwmon->base)) + return PTR_ERR(hwmon->base); + + err = devm_add_action(&pdev->dev, s5_temp_disable, hwmon); + if (err) + return err; + + s5_temp_enable(hwmon); + + hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev, + "s5_temp", + hwmon, + &s5_chip_info, + NULL); + + return PTR_ERR_OR_ZERO(hwmon_dev); +} + +const struct of_device_id s5_temp_match[] = { + { .compatible = "microchip,sparx5-temp" }, + {}, +}; +MODULE_DEVICE_TABLE(of, s5_temp_match); + +static struct platform_driver s5_temp_driver = { + .probe = s5_temp_probe, + .driver = { + .name = "sparx5-temp", + .of_match_table = s5_temp_match, + }, +}; + +module_platform_driver(s5_temp_driver); + +MODULE_AUTHOR("Lars Povlsen <lars.povlsen@microchip.com>"); +MODULE_DESCRIPTION("Sparx5 SoC temperature sensor driver"); +MODULE_LICENSE("GPL"); -- 2.26.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] hwmon: sparx5: Add Sparx5 SoC temperature driver 2020-05-13 13:41 ` [PATCH 3/3] hwmon: sparx5: Add Sparx5 SoC temperature driver Lars Povlsen @ 2020-05-13 15:20 ` Guenter Roeck 2020-05-18 9:57 ` Lars Povlsen 0 siblings, 1 reply; 8+ messages in thread From: Guenter Roeck @ 2020-05-13 15:20 UTC (permalink / raw) To: Lars Povlsen Cc: SoC Team, Jean Delvare, Microchip Linux Driver Support, linux-hwmon, devicetree, linux-arm-kernel, linux-kernel, Alexandre Belloni On Wed, May 13, 2020 at 03:41:40PM +0200, Lars Povlsen wrote: > This patch adds a temperature sensor driver to the Sparx5 SoC. > > Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com> > --- > drivers/hwmon/Kconfig | 10 +++ > drivers/hwmon/Makefile | 2 +- > drivers/hwmon/sparx5-temp.c | 154 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 165 insertions(+), 1 deletion(-) > create mode 100644 drivers/hwmon/sparx5-temp.c > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index 4c62f900bf7e8..130cb1f1748ff 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -480,6 +480,16 @@ config SENSORS_I5K_AMB > This driver can also be built as a module. If so, the module > will be called i5k_amb. > > +config SENSORS_SPARX5 > + tristate "Sparx5 SoC temperature sensor" > + depends on ARCH_SPARX5 > + help > + If you say yes here you get support for temperature monitoring > + with the Microchip Sparx5 SoC. > + > + This driver can also be built as a module. If so, the module > + will be called sparx5-temp. > + > config SENSORS_F71805F > tristate "Fintek F71805F/FG, F71806F/FG and F71872F/FG" > depends on !PPC > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile > index b0b9c8e571762..28a09986b7a62 100644 > --- a/drivers/hwmon/Makefile > +++ b/drivers/hwmon/Makefile > @@ -64,6 +64,7 @@ obj-$(CONFIG_SENSORS_DS1621) += ds1621.o > obj-$(CONFIG_SENSORS_EMC1403) += emc1403.o > obj-$(CONFIG_SENSORS_EMC2103) += emc2103.o > obj-$(CONFIG_SENSORS_EMC6W201) += emc6w201.o > +obj-$(CONFIG_SENSORS_SPARX5) += sparx5-temp.o > obj-$(CONFIG_SENSORS_F71805F) += f71805f.o > obj-$(CONFIG_SENSORS_F71882FG) += f71882fg.o > obj-$(CONFIG_SENSORS_F75375S) += f75375s.o > @@ -190,4 +191,3 @@ obj-$(CONFIG_SENSORS_OCC) += occ/ > obj-$(CONFIG_PMBUS) += pmbus/ > > ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG > - > diff --git a/drivers/hwmon/sparx5-temp.c b/drivers/hwmon/sparx5-temp.c > new file mode 100644 > index 0000000000000..bf9dd102a9825 > --- /dev/null > +++ b/drivers/hwmon/sparx5-temp.c > @@ -0,0 +1,154 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* Sparx5 SoC temperature sensor driver > + * > + * Copyright (C) 2020 Lars Povlsen <lars.povlsen@microchip.com> > + */ > + > +#include <linux/bitops.h> > +#include <linux/hwmon.h> > +#include <linux/hwmon-sysfs.h> Unnecessary include > +#include <linux/init.h> > +#include <linux/io.h> > +#include <linux/module.h> > +#include <linux/of_device.h> > + > +#define TEMP_CTRL 0 > +#define TEMP_CFG 4 > +#define TEMP_CFG_CYCLES GENMASK(24, 15) > +#define TEMP_CFG_CYCLES_OFF 15 > +#define TEMP_CFG_ENA BIT(0) > +#define TEMP_STAT 8 > +#define TEMP_STAT_VALID BIT(12) > +#define TEMP_STAT_TEMP GENMASK(11, 0) > + > +struct s5_hwmon { > + void __iomem *base; > +}; > + > +static void s5_temp_enable(struct s5_hwmon *hwmon) > +{ > + u32 val = readl(hwmon->base + TEMP_CFG); > + u32 clk = 250; > + > + val &= ~TEMP_CFG_CYCLES; > + val |= (clk << TEMP_CFG_CYCLES_OFF); > + val |= TEMP_CFG_ENA; > + > + writel(val, hwmon->base + TEMP_CFG); > +} > + > +static void s5_temp_disable(void *data) > +{ > + struct s5_hwmon *hwmon = data; > + u32 val = readl(hwmon->base + TEMP_CFG); > + > + val &= ~TEMP_CFG_ENA; > + > + writel(val, hwmon->base + TEMP_CFG); > +} > + > +static int s5_read(struct device *dev, enum hwmon_sensor_types type, > + u32 attr, int channel, long *temp) > +{ > + struct s5_hwmon *hwmon = dev_get_drvdata(dev); > + int rc = 0, value; > + u32 stat; > + > + switch (attr) { > + case hwmon_temp_input: > + stat = readl_relaxed(hwmon->base + TEMP_STAT); > + if (stat & TEMP_STAT_VALID) { > + value = (stat & TEMP_STAT_TEMP); Unnecessary ( ) > + value = DIV_ROUND_CLOSEST(value * 3522, 4096) - 1094; > + value *= 100; > + *temp = value; > + } else > + rc = -EINVAL; -EINVAL is for bad used input. -EIO, maybe, unless there is a better error. Also, if (!(stat & TEMP_STAT_VALID)) return -EIO; ... would be easier to read (and not result in a checkpatch warning). > + break; > + default: > + rc = -EOPNOTSUPP; break; > + } > + > + return rc; > +} > + > +static umode_t s5_is_visible(const void *_data, enum hwmon_sensor_types type, > + u32 attr, int channel) > +{ > + if (type != hwmon_temp) > + return 0; > + > + switch (attr) { > + case hwmon_temp_input: > + return 0444; > + default: > + return 0; > + } > +} > + > +static const struct hwmon_channel_info *s5_info[] = { > + HWMON_CHANNEL_INFO(chip, > + HWMON_C_REGISTER_TZ), > + HWMON_CHANNEL_INFO(temp, > + HWMON_T_INPUT), > + NULL > +}; > + > +static const struct hwmon_ops s5_hwmon_ops = { > + .is_visible = s5_is_visible, > + .read = s5_read, > +}; > + > +static const struct hwmon_chip_info s5_chip_info = { > + .ops = &s5_hwmon_ops, > + .info = s5_info, > +}; > + > +static int s5_temp_probe(struct platform_device *pdev) > +{ > + struct device *hwmon_dev; > + struct s5_hwmon *hwmon; > + int err = 0; Unnecessary initialization > + > + hwmon = devm_kzalloc(&pdev->dev, sizeof(*hwmon), GFP_KERNEL); > + if (!hwmon) > + return -ENOMEM; > + > + hwmon->base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(hwmon->base)) > + return PTR_ERR(hwmon->base); > + > + err = devm_add_action(&pdev->dev, s5_temp_disable, hwmon); > + if (err) > + return err; > + > + s5_temp_enable(hwmon); > + > + hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev, > + "s5_temp", > + hwmon, > + &s5_chip_info, > + NULL); > + > + return PTR_ERR_OR_ZERO(hwmon_dev); > +} > + > +const struct of_device_id s5_temp_match[] = { > + { .compatible = "microchip,sparx5-temp" }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, s5_temp_match); > + > +static struct platform_driver s5_temp_driver = { > + .probe = s5_temp_probe, > + .driver = { > + .name = "sparx5-temp", > + .of_match_table = s5_temp_match, > + }, > +}; > + > +module_platform_driver(s5_temp_driver); > + > +MODULE_AUTHOR("Lars Povlsen <lars.povlsen@microchip.com>"); > +MODULE_DESCRIPTION("Sparx5 SoC temperature sensor driver"); > +MODULE_LICENSE("GPL"); > -- > 2.26.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] hwmon: sparx5: Add Sparx5 SoC temperature driver 2020-05-13 15:20 ` Guenter Roeck @ 2020-05-18 9:57 ` Lars Povlsen 0 siblings, 0 replies; 8+ messages in thread From: Lars Povlsen @ 2020-05-18 9:57 UTC (permalink / raw) To: Guenter Roeck Cc: Lars Povlsen, SoC Team, Jean Delvare, Microchip Linux Driver Support, linux-hwmon, devicetree, linux-arm-kernel, linux-kernel, Alexandre Belloni Guenter Roeck writes: > On Wed, May 13, 2020 at 03:41:40PM +0200, Lars Povlsen wrote: >> This patch adds a temperature sensor driver to the Sparx5 SoC. >> >> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> >> Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com> >> --- >> drivers/hwmon/Kconfig | 10 +++ >> drivers/hwmon/Makefile | 2 +- >> drivers/hwmon/sparx5-temp.c | 154 ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 165 insertions(+), 1 deletion(-) >> create mode 100644 drivers/hwmon/sparx5-temp.c >> >> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig >> index 4c62f900bf7e8..130cb1f1748ff 100644 >> --- a/drivers/hwmon/Kconfig >> +++ b/drivers/hwmon/Kconfig >> @@ -480,6 +480,16 @@ config SENSORS_I5K_AMB >> This driver can also be built as a module. If so, the module >> will be called i5k_amb. >> >> +config SENSORS_SPARX5 >> + tristate "Sparx5 SoC temperature sensor" >> + depends on ARCH_SPARX5 >> + help >> + If you say yes here you get support for temperature monitoring >> + with the Microchip Sparx5 SoC. >> + >> + This driver can also be built as a module. If so, the module >> + will be called sparx5-temp. >> + >> config SENSORS_F71805F >> tristate "Fintek F71805F/FG, F71806F/FG and F71872F/FG" >> depends on !PPC >> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile >> index b0b9c8e571762..28a09986b7a62 100644 >> --- a/drivers/hwmon/Makefile >> +++ b/drivers/hwmon/Makefile >> @@ -64,6 +64,7 @@ obj-$(CONFIG_SENSORS_DS1621) += ds1621.o >> obj-$(CONFIG_SENSORS_EMC1403) += emc1403.o >> obj-$(CONFIG_SENSORS_EMC2103) += emc2103.o >> obj-$(CONFIG_SENSORS_EMC6W201) += emc6w201.o >> +obj-$(CONFIG_SENSORS_SPARX5) += sparx5-temp.o >> obj-$(CONFIG_SENSORS_F71805F) += f71805f.o >> obj-$(CONFIG_SENSORS_F71882FG) += f71882fg.o >> obj-$(CONFIG_SENSORS_F75375S) += f75375s.o >> @@ -190,4 +191,3 @@ obj-$(CONFIG_SENSORS_OCC) += occ/ >> obj-$(CONFIG_PMBUS) += pmbus/ >> >> ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG >> - >> diff --git a/drivers/hwmon/sparx5-temp.c b/drivers/hwmon/sparx5-temp.c >> new file mode 100644 >> index 0000000000000..bf9dd102a9825 >> --- /dev/null >> +++ b/drivers/hwmon/sparx5-temp.c >> @@ -0,0 +1,154 @@ >> +// SPDX-License-Identifier: GPL-2.0-or-later >> +/* Sparx5 SoC temperature sensor driver >> + * >> + * Copyright (C) 2020 Lars Povlsen <lars.povlsen@microchip.com> >> + */ >> + >> +#include <linux/bitops.h> >> +#include <linux/hwmon.h> >> +#include <linux/hwmon-sysfs.h> > > Unnecessary include Ack. > >> +#include <linux/init.h> >> +#include <linux/io.h> >> +#include <linux/module.h> >> +#include <linux/of_device.h> >> + >> +#define TEMP_CTRL 0 >> +#define TEMP_CFG 4 >> +#define TEMP_CFG_CYCLES GENMASK(24, 15) >> +#define TEMP_CFG_CYCLES_OFF 15 >> +#define TEMP_CFG_ENA BIT(0) >> +#define TEMP_STAT 8 >> +#define TEMP_STAT_VALID BIT(12) >> +#define TEMP_STAT_TEMP GENMASK(11, 0) >> + >> +struct s5_hwmon { >> + void __iomem *base; >> +}; >> + >> +static void s5_temp_enable(struct s5_hwmon *hwmon) >> +{ >> + u32 val = readl(hwmon->base + TEMP_CFG); >> + u32 clk = 250; >> + >> + val &= ~TEMP_CFG_CYCLES; >> + val |= (clk << TEMP_CFG_CYCLES_OFF); >> + val |= TEMP_CFG_ENA; >> + >> + writel(val, hwmon->base + TEMP_CFG); >> +} >> + >> +static void s5_temp_disable(void *data) >> +{ >> + struct s5_hwmon *hwmon = data; >> + u32 val = readl(hwmon->base + TEMP_CFG); >> + >> + val &= ~TEMP_CFG_ENA; >> + >> + writel(val, hwmon->base + TEMP_CFG); >> +} >> + >> +static int s5_read(struct device *dev, enum hwmon_sensor_types type, >> + u32 attr, int channel, long *temp) >> +{ >> + struct s5_hwmon *hwmon = dev_get_drvdata(dev); >> + int rc = 0, value; >> + u32 stat; >> + >> + switch (attr) { >> + case hwmon_temp_input: >> + stat = readl_relaxed(hwmon->base + TEMP_STAT); >> + if (stat & TEMP_STAT_VALID) { >> + value = (stat & TEMP_STAT_TEMP); > > Unnecessary ( ) Removed. > >> + value = DIV_ROUND_CLOSEST(value * 3522, 4096) - 1094; >> + value *= 100; >> + *temp = value; >> + } else >> + rc = -EINVAL; > > -EINVAL is for bad used input. -EIO, maybe, unless there is a better error. > Also, > > if (!(stat & TEMP_STAT_VALID)) > return -EIO; Ok, changed. > ... > > would be easier to read (and not result in a checkpatch warning). > >> + break; >> + default: >> + rc = -EOPNOTSUPP; > > break; > Added. >> + } >> + >> + return rc; >> +} >> + >> +static umode_t s5_is_visible(const void *_data, enum hwmon_sensor_types type, >> + u32 attr, int channel) >> +{ >> + if (type != hwmon_temp) >> + return 0; >> + >> + switch (attr) { >> + case hwmon_temp_input: >> + return 0444; >> + default: >> + return 0; >> + } >> +} >> + >> +static const struct hwmon_channel_info *s5_info[] = { >> + HWMON_CHANNEL_INFO(chip, >> + HWMON_C_REGISTER_TZ), >> + HWMON_CHANNEL_INFO(temp, >> + HWMON_T_INPUT), >> + NULL >> +}; >> + >> +static const struct hwmon_ops s5_hwmon_ops = { >> + .is_visible = s5_is_visible, >> + .read = s5_read, >> +}; >> + >> +static const struct hwmon_chip_info s5_chip_info = { >> + .ops = &s5_hwmon_ops, >> + .info = s5_info, >> +}; >> + >> +static int s5_temp_probe(struct platform_device *pdev) >> +{ >> + struct device *hwmon_dev; >> + struct s5_hwmon *hwmon; >> + int err = 0; > > Unnecessary initialization > Removed >> + >> + hwmon = devm_kzalloc(&pdev->dev, sizeof(*hwmon), GFP_KERNEL); >> + if (!hwmon) >> + return -ENOMEM; >> + >> + hwmon->base = devm_platform_ioremap_resource(pdev, 0); >> + if (IS_ERR(hwmon->base)) >> + return PTR_ERR(hwmon->base); >> + >> + err = devm_add_action(&pdev->dev, s5_temp_disable, hwmon); >> + if (err) >> + return err; >> + >> + s5_temp_enable(hwmon); >> + >> + hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev, >> + "s5_temp", >> + hwmon, >> + &s5_chip_info, >> + NULL); >> + >> + return PTR_ERR_OR_ZERO(hwmon_dev); >> +} >> + >> +const struct of_device_id s5_temp_match[] = { >> + { .compatible = "microchip,sparx5-temp" }, >> + {}, >> +}; >> +MODULE_DEVICE_TABLE(of, s5_temp_match); >> + >> +static struct platform_driver s5_temp_driver = { >> + .probe = s5_temp_probe, >> + .driver = { >> + .name = "sparx5-temp", >> + .of_match_table = s5_temp_match, >> + }, >> +}; >> + >> +module_platform_driver(s5_temp_driver); >> + >> +MODULE_AUTHOR("Lars Povlsen <lars.povlsen@microchip.com>"); >> +MODULE_DESCRIPTION("Sparx5 SoC temperature sensor driver"); >> +MODULE_LICENSE("GPL"); >> -- >> 2.26.2 Thank you for your input, I will submit anew asap. ---Lars -- Lars Povlsen, Microchip ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-05-28 3:39 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-13 13:41 [PATCH 0/3] hwmon: Adding support for Microchip Sparx5 SoC Lars Povlsen 2020-05-13 13:41 ` [PATCH 1/3] dt-bindings: hwmon: Add Sparx5 temperature sensor Lars Povlsen 2020-05-13 13:41 ` [PATCH 2/3] arm64: dts: sparx5: Add hwmon " Lars Povlsen 2020-05-28 2:29 ` Rob Herring 2020-05-28 3:39 ` Alexandre Belloni 2020-05-13 13:41 ` [PATCH 3/3] hwmon: sparx5: Add Sparx5 SoC temperature driver Lars Povlsen 2020-05-13 15:20 ` Guenter Roeck 2020-05-18 9:57 ` Lars Povlsen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).