Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
* Re: [v1,1/1] hwmon: (nct7904) Add to read all of the SMI status registers in probe function.
@ 2020-05-13 15:21 Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-05-13 15:21 UTC (permalink / raw)
  To: Amy.Shih
  Cc: she90122, Jean Delvare, linux-hwmon, linux-kernel, oakley.ding,
	jia.sui, yuechao.zhao, Hy.Lee

On Tue, May 12, 2020 at 02:25:23AM +0000, Amy.Shih@advantech.com.tw wrote:
> From: Amy Shih <amy.shih@advantech.com.tw>
> 
> When nct7904 power up, it compares current sensor readings within the
> default threshold immediately, thus some of SMI status registers would
> get non zero values cause the false alarms on first reading. Add to
> read all of the SMI status registers in probe function to clear the
> alarms.
> 
> Signed-off-by: Amy Shih <amy.shih@advantech.com.tw>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/nct7904.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 571a649..6fb06f7 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -45,6 +45,7 @@
>  #define FANCTL_MAX		4	/* Counted from 1 */
>  #define TCPU_MAX		8	/* Counted from 1 */
>  #define TEMP_MAX		4	/* Counted from 1 */
> +#define SMI_STS_MAX		10	/* Counted from 1 */
>  
>  #define VT_ADC_CTRL0_REG	0x20	/* Bank 0 */
>  #define VT_ADC_CTRL1_REG	0x21	/* Bank 0 */
> @@ -1126,6 +1127,13 @@ static int nct7904_probe(struct i2c_client *client,
>  		data->fan_mode[i] = ret;
>  	}
>  
> +	/* Read all of SMI status register to clear alarms */
> +	for (i = 0; i < SMI_STS_MAX; i++) {
> +		ret = nct7904_read_reg(data, BANK_0, SMI_STS1_REG + i);
> +		if (ret < 0)
> +			return ret;
> +	}
> +
>  	hwmon_dev =
>  		devm_hwmon_device_register_with_info(dev, client->name, data,
>  						     &nct7904_chip_info, NULL);
> -- 
> 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [v1,1/1] hwmon: (nct7904) Add to read all of the SMI status registers in probe function.
@ 2020-05-12  2:25 Amy.Shih
  0 siblings, 0 replies; 2+ messages in thread
From: Amy.Shih @ 2020-05-12  2:25 UTC (permalink / raw)
  To: she90122
  Cc: Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel, amy.shih,
	oakley.ding, jia.sui, yuechao.zhao, Hy.Lee

From: Amy Shih <amy.shih@advantech.com.tw>

When nct7904 power up, it compares current sensor readings within the
default threshold immediately, thus some of SMI status registers would
get non zero values cause the false alarms on first reading. Add to
read all of the SMI status registers in probe function to clear the
alarms.

Signed-off-by: Amy Shih <amy.shih@advantech.com.tw>
---
 drivers/hwmon/nct7904.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
index 571a649..6fb06f7 100644
--- a/drivers/hwmon/nct7904.c
+++ b/drivers/hwmon/nct7904.c
@@ -45,6 +45,7 @@
 #define FANCTL_MAX		4	/* Counted from 1 */
 #define TCPU_MAX		8	/* Counted from 1 */
 #define TEMP_MAX		4	/* Counted from 1 */
+#define SMI_STS_MAX		10	/* Counted from 1 */
 
 #define VT_ADC_CTRL0_REG	0x20	/* Bank 0 */
 #define VT_ADC_CTRL1_REG	0x21	/* Bank 0 */
@@ -1126,6 +1127,13 @@ static int nct7904_probe(struct i2c_client *client,
 		data->fan_mode[i] = ret;
 	}
 
+	/* Read all of SMI status register to clear alarms */
+	for (i = 0; i < SMI_STS_MAX; i++) {
+		ret = nct7904_read_reg(data, BANK_0, SMI_STS1_REG + i);
+		if (ret < 0)
+			return ret;
+	}
+
 	hwmon_dev =
 		devm_hwmon_device_register_with_info(dev, client->name, data,
 						     &nct7904_chip_info, NULL);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 15:21 [v1,1/1] hwmon: (nct7904) Add to read all of the SMI status registers in probe function Guenter Roeck
  -- strict thread matches above, loose matches on Subject: below --
2020-05-12  2:25 Amy.Shih

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git