From: Guenter Roeck <linux@roeck-us.net>
To: yuechao.zhao@advantech.com.cn
Cc: 345351830@qq.com, amy.shih@advantech.com.tw,
oakley.ding@advantech.com.tw, jia.sui@advantech.com.cn,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v1,1/1] watchdog: (nct7904) Fix enable watchdog incorrectly
Date: Wed, 13 May 2020 08:24:50 -0700 [thread overview]
Message-ID: <20200513152450.GA180616@roeck-us.net> (raw)
On Wed, May 13, 2020 at 11:00:15AM +0000, yuechao.zhao@advantech.com.cn wrote:
> From: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
>
> Use incorrect register to enable watchdog in nct7904_wdt_ping()
>
> Signed-off-by: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
I merged this patch into the patch introducing watchdog support.
Thanks,
Guenter
> ---
> drivers/hwmon/nct7904.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 04f2a8e..18c95be 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -979,7 +979,7 @@ static int nct7904_wdt_ping(struct watchdog_device *wdt)
> return ret;
>
> /* Enable soft watchdog timer */
> - return nct7904_write_reg(data, BANK_0, WDT_TIMER_REG, WDT_SOFT_EN);
> + return nct7904_write_reg(data, BANK_0, WDT_LOCK_REG, WDT_SOFT_EN);
> }
>
> static unsigned int nct7904_wdt_get_timeleft(struct watchdog_device *wdt)
> --
> 1.8.3.1
>
next reply other threads:[~2020-05-13 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 15:24 Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-13 11:00 [v1,1/1] watchdog: (nct7904) Fix enable watchdog incorrectly yuechao.zhao
2020-05-13 13:16 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513152450.GA180616@roeck-us.net \
--to=linux@roeck-us.net \
--cc=345351830@qq.com \
--cc=amy.shih@advantech.com.tw \
--cc=jdelvare@suse.com \
--cc=jia.sui@advantech.com.cn \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oakley.ding@advantech.com.tw \
--cc=yuechao.zhao@advantech.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).