From: Guenter Roeck <linux@roeck-us.net>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
Jean Delvare <jdelvare@suse.com>,
Lee Jones <lee.jones@linaro.org>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, Samu Nuutamo <samu.nuutamo@vincit.fi>
Subject: Re: [PATCH] hwmon: da9052: Synchronize access with mfd
Date: Wed, 13 May 2020 10:07:44 -0700 [thread overview]
Message-ID: <20200513170744.GA133638@roeck-us.net> (raw)
On Mon, May 11, 2020 at 01:02:19PM +0200, Sebastian Reichel wrote:
> From: Samu Nuutamo <samu.nuutamo@vincit.fi>
>
> When tsi-as-adc is configured it is possible for in7[0123]_input read to
> return an incorrect value if a concurrent read to in[456]_input is
> performed. This is caused by a concurrent manipulation of the mux
> channel without proper locking as hwmon and mfd use different locks for
> synchronization.
>
> Switch hwmon to use the same lock as mfd when accessing the TSI channel.
>
> Fixes: 4f16cab19a3d5 ("hwmon: da9052: Add support for TSI channel")
> Signed-off-by: Samu Nuutamo <samu.nuutamo@vincit.fi>
> [rebase to current master, reword commit message slightly]
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Applied.
Thanks,
Guenter
next reply other threads:[~2020-05-13 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 17:07 Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-11 11:02 [PATCH] hwmon: da9052: Synchronize access with mfd Sebastian Reichel
2020-05-11 16:51 ` Guenter Roeck
2020-05-12 11:31 ` Sebastian Reichel
2019-03-18 14:29 [PATCH] hwmon: (da9052) " Samu Nuutamo
2019-03-18 14:51 ` Guenter Roeck
2019-03-19 13:38 ` Samu Nuutamo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513170744.GA133638@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samu.nuutamo@vincit.fi \
--cc=sebastian.reichel@collabora.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).