Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: zhenghaili <hailizheng1993@gmail.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	hailizheng <haili.zheng@powercore.com.cn>
Subject: Re: [PATCH] drivers/hwmon/nct7802: Replace container_of() API
Date: Fri, 22 May 2020 06:22:51 -0700
Message-ID: <20200522132251.GA221470@roeck-us.net> (raw)
In-Reply-To: <1589891119-16508-1-git-send-email-haili.zheng@powercore.com.cn>

On Tue, May 19, 2020 at 08:25:19AM -0400, zhenghaili wrote:
> From: hailizheng <haili.zheng@powercore.com.cn>
> 
> Replace container_of() API with kobj_to_dev().
> 
> Signed-off-by: hailizheng <haili.zheng@powercore.com.cn>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/nct7802.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
> index 2e97e56..570df8e 100644
> --- a/drivers/hwmon/nct7802.c
> +++ b/drivers/hwmon/nct7802.c
> @@ -679,7 +679,7 @@ static struct attribute *nct7802_temp_attrs[] = {
>  static umode_t nct7802_temp_is_visible(struct kobject *kobj,
>  				       struct attribute *attr, int index)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct nct7802_data *data = dev_get_drvdata(dev);
>  	unsigned int reg;
>  	int err;
> @@ -778,7 +778,7 @@ static struct attribute *nct7802_in_attrs[] = {
>  static umode_t nct7802_in_is_visible(struct kobject *kobj,
>  				     struct attribute *attr, int index)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct nct7802_data *data = dev_get_drvdata(dev);
>  	unsigned int reg;
>  	int err;
> @@ -853,7 +853,7 @@ static struct attribute *nct7802_fan_attrs[] = {
>  static umode_t nct7802_fan_is_visible(struct kobject *kobj,
>  				      struct attribute *attr, int index)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct nct7802_data *data = dev_get_drvdata(dev);
>  	int fan = index / 4;	/* 4 attributes per fan */
>  	unsigned int reg;

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 12:25 zhenghaili
2020-05-22 13:22 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522132251.GA221470@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=haili.zheng@powercore.com.cn \
    --cc=hailizheng1993@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git