From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Lars Povlsen <lars.povlsen@microchip.com>,
Guenter Roeck <linux@roeck-us.net>, SoC Team <soc@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: sparx5: Add hwmon temperature sensor
Date: Thu, 28 May 2020 05:39:41 +0200 [thread overview]
Message-ID: <20200528033941.GQ3972@piout.net> (raw)
In-Reply-To: <20200528022931.GA3238321@bogus>
Hi Rob,
On 27/05/2020 20:29:31-0600, Rob Herring wrote:
> On Wed, May 13, 2020 at 03:41:39PM +0200, Lars Povlsen wrote:
> > This adds a hwmon temperature node sensor to the Sparx5 SoC.
> >
> > Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com>
> > ---
> > arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi
> > index f09a49c41ce19..b5f2d088af30e 100644
> > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi
> > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi
> > @@ -233,5 +233,11 @@ i2c1: i2c@600103000 {
> > clock-frequency = <100000>;
> > clocks = <&ahb_clk>;
> > };
> > +
> > + tmon0: tmon@610508110 {
> > + compatible = "microchip,sparx5-temp";
> > + reg = <0x6 0x10508110 0xc>;
>
> These nodes are all very odd with a couple of registers spread out at
> randomish addresses. DT nodes should roughly correlate to h/w blocks,
> not sets of registers for a driver like this seems to be.
>
The DT nodes correlates to HW block, this and the previous families of
SoCs were designed with packed registers. There is no padding between HW
block registers.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-05-28 3:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 13:41 [PATCH 0/3] hwmon: Adding support for Microchip Sparx5 SoC Lars Povlsen
2020-05-13 13:41 ` [PATCH 1/3] dt-bindings: hwmon: Add Sparx5 temperature sensor Lars Povlsen
2020-05-13 13:41 ` [PATCH 2/3] arm64: dts: sparx5: Add hwmon " Lars Povlsen
2020-05-28 2:29 ` Rob Herring
2020-05-28 3:39 ` Alexandre Belloni [this message]
2020-05-13 13:41 ` [PATCH 3/3] hwmon: sparx5: Add Sparx5 SoC temperature driver Lars Povlsen
2020-05-13 15:20 ` Guenter Roeck
2020-05-18 9:57 ` Lars Povlsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528033941.GQ3972@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).