From: Greg KH <greg@kroah.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: jaap aarts <jaap.aarts1@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org,
Marius Zachmann <mail@mariuszachmann.de>
Subject: Re: [PATCH] hwmon: add fan/pwm driver for corsair h100i platinum
Date: Wed, 15 Jul 2020 10:34:52 +0200 [thread overview]
Message-ID: <20200715083452.GC2716443@kroah.com> (raw)
In-Reply-To: <20200715030740.GB164279@roeck-us.net>
On Tue, Jul 14, 2020 at 08:07:40PM -0700, Guenter Roeck wrote:
> On Tue, Jul 14, 2020 at 12:03:38PM +0200, jaap aarts wrote:
> > Adds fan/pwm support for H1000i platinum.
> > Custom temp/fan curves are not supported, however
> > the presets found in the proprietary drivers are avaiable.
> >
> > Signed-off-by: Jaap Aarts <jaap.aarts1@gmail.com>
>
> +Marius Zachmann for input.
>
> Questions:
> - Does this really have to be a different driver or can it be merged into
> the corsair-cpro driver ?
> - What about HID vs. USB driver ?
> - is the kref complexity really needed ?
At first glance, I can't tell what the kref is trying to keep track of.
So I would say no, it's not. :)
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-15 8:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 10:03 [PATCH] hwmon: add fan/pwm driver for corsair h100i platinum jaap aarts
2020-07-14 23:01 ` kernel test robot
2020-07-15 3:07 ` Guenter Roeck
2020-07-15 8:34 ` Greg KH [this message]
2020-07-15 11:18 ` jaap aarts
2020-07-15 14:47 ` Guenter Roeck
2020-07-15 15:03 ` jaap aarts
2020-07-15 15:10 ` Guenter Roeck
2020-07-15 12:17 ` Marius Zachmann
2020-07-15 14:20 ` Guenter Roeck
2020-07-17 12:20 ` jaap aarts
2020-07-23 9:17 jaap aarts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715083452.GC2716443@kroah.com \
--to=greg@kroah.com \
--cc=jaap.aarts1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mail@mariuszachmann.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).