From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11932C433DF for ; Tue, 28 Jul 2020 08:56:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE83120786 for ; Tue, 28 Jul 2020 08:56:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SgmKbxsh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726032AbgG1I4W (ORCPT ); Tue, 28 Jul 2020 04:56:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728250AbgG1I4V (ORCPT ); Tue, 28 Jul 2020 04:56:21 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF807C0619D5 for ; Tue, 28 Jul 2020 01:56:20 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id 88so17468929wrh.3 for ; Tue, 28 Jul 2020 01:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wxTwrgnq9E/WiNk3kV+5CMVUMO6IYGLUJRsXmpueos0=; b=SgmKbxshWIgy7i/i8vqaI5tcJ2bU9gb64Sjar5YKhBEB9iRFEBzg3k9HrxnHFKOSOs zMcnsMKMr8P3PuxxZvVa0Ir4j3kWZgXjk2nPksQHELB7nSQggAJnMs7JY2nOvsJ+GTyc sIiabW7fz/o12PIx2L6NxjeBcGNbm096zWnTV1cVN3V+7GI56cqEkWoS5K7sGXi1aM9m 1knClukA542+MNKmOGARWM3fcYgIfXhxS0F2pay/Q5sEMEVLSN/zk8GkjyMscM7sqgyD YpxFhjMDccQmmVdIisDgzl/kMCQRrp8Zbjd/gxKYKRbEEJIQ6UoCMBONxNgeMkHczaNP XxdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wxTwrgnq9E/WiNk3kV+5CMVUMO6IYGLUJRsXmpueos0=; b=XBPpGouVGY/7UucmsLlqTjdrIrM178ra020HJy0aAXxlIAwvbJ+UhgWqqKpEzjHmyS sfzuQSiwQKQY6aju/124+aaHuOfL75RESUAfKvyUZB/FxJuqJzOBs1Mp2wclBfvaRK+B 3Kzpahi98eJFIr4Kuaj/UvpJ+qL48d4fGHAoRs6vIbRM9W7QN61NeyArJ1yjmxVmJla5 pi9qOTUeHGVyYWh8th5hH4hqj7y76+tCW0CKdgNGFgEW5KIn4RdYHWI0aSFSSVL6HIuF AddHPxLIb7mkTfWRIHjyf99swrCQt63PAecgSVxfPlDSo6DtiG4EG6RU9RmlMjXZaXHd Bjsw== X-Gm-Message-State: AOAM532QDOrtPK8IxMIEBzk2dMZcgaq8CU+HLBKS9ARfBFcYEq5Uipyx mSaKuAOMhJw6hZ8fxpbIL5j3Lw== X-Google-Smtp-Source: ABdhPJzyefbTUcC6FA1OtyHG3ZE+ihx1cIgJ8kJah012w56nbIM6+qpRfcUIjerKX0Iu0TxyY/d/Tw== X-Received: by 2002:adf:f045:: with SMTP id t5mr25467199wro.288.1595926579385; Tue, 28 Jul 2020 01:56:19 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id a10sm12662484wro.35.2020.07.28.01.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2020 01:56:18 -0700 (PDT) Date: Tue, 28 Jul 2020 09:56:16 +0100 From: Lee Jones To: Michael Walle Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , Andy Shevchenko , Catalin Marinas , Will Deacon , Pavel Machek , Rob Herring Subject: Re: [PATCH v6 02/13] dt-bindings: mfd: Add bindings for sl28cpld Message-ID: <20200728085616.GD2419169@dell> References: <20200725231834.25642-1-michael@walle.cc> <20200725231834.25642-3-michael@walle.cc> <20200728072422.GF1850026@dell> <1065b0107ce6fd88b2bdd704bf45346b@walle.cc> <20200728082707.GB2419169@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org > > > > > +$id: http://devicetree.org/schemas/mfd/kontron,sl28cpld.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: Kontron's sl28cpld board management controller > > > > > > > > "S128CPLD" ? > > > > > > still not, its sl28cpld, think of a project/code name, not the product > > > appended with CPLD. > > > > > > > "Board Management Controller (BMC)" ? > > > > > > sounds like IPMI, which I wanted to avoid. > > > > Is there a datasheet? > > No there isn't. Then what are you working from? > > > > > +maintainers: > > > > > + - Michael Walle > > > > > + > > > > > +description: | > > > > > + The board management controller may contain different IP blocks > > > > > like > > > > > + watchdog, fan monitoring, PWM controller, interrupt controller > > > > > and a > > > > > + GPIO controller. > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + const: kontron,sl28cpld-r1 > > > > > > > > We don't usually code revision numbers in compatible strings. > > > > > > > > Is there any way to pull this from the H/W? > > > > > > No, unfortunately you can't. And I really want to keep that, in case > > > in the future there are some backwards incompatible changes. > > > > Rob, > > > > I know you reviewed this already, but you can give your opinion on > > this specifically please? I know that we have pushed back on this in > > the past. > > Oh, come one. That is an arbitrary string. "sl28cpld-r1" is the first > implementation of this. A future "sl28cpld-r2" might look completely > different and might not suite the simple MFD at all. "sl28cpld" is > a made up name - as "sl28cpld-r1" is, too. Well that sounds bogus for a start. I guess that's one of the problems with trying to support programmable H/W in S/W. If it's okay with Rob, then I'll be okay with it. Just to note, this has not been okay for others in the past, and this use-case is not 'special'. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog