From: Rob Herring <robh@kernel.org>
To: Campion Kang <campion.kang@advantech.com.tw>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-hwmon@vger.kernel.org, linux-watchdog@vger.kernel.org,
AceLan Kao <chia-lin.kao@canonical.com>
Subject: Re: [PATCH v6 3/6] dt-bindings: mfd: ahc1ec0.yaml: Add Advantech embedded controller - AHC1EC0
Date: Fri, 5 Feb 2021 15:21:33 -0600 [thread overview]
Message-ID: <20210205212133.GA3759495@robh.at.kernel.org> (raw)
In-Reply-To: <20210118123749.4769-3-campion.kang@advantech.com.tw>
On Mon, Jan 18, 2021 at 08:37:46PM +0800, Campion Kang wrote:
> Add DT binding schema for Advantech embedded controller AHC1EC0.
>
> Changed since V5:
> - rename dt-bindings/mfd/ahc1ec0.h to dt-bindings/mfd/ahc1ec0-dt.h
> that found errors by bot 'make dt_binding_check'
>
> Signed-off-by: Campion Kang <campion.kang@advantech.com.tw>
> ---
> .../devicetree/bindings/mfd/ahc1ec0.yaml | 69 +++++++++++++++++++
> 1 file changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/ahc1ec0.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/ahc1ec0.yaml b/Documentation/devicetree/bindings/mfd/ahc1ec0.yaml
> new file mode 100644
> index 000000000000..40af14bb9c0a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ahc1ec0.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ahc1ec0.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Advantech Embedded Controller (AHC1EC0)
> +
> +maintainers:
> + - Campion Kang <campion.kang@advantech.com.tw>
> +
> +description: |
> + AHC1EC0 is one of the embedded controllers used by Advantech to provide several
> + functions such as watchdog, hwmon, brightness, etc. Advantech related applications
> + can control the whole system via these functions.
> +
> +properties:
> + compatible:
> + const: advantech,ahc1ec0
> +
> + advantech,sub-dev-nb:
> + description:
> + The number of sub-devices specified in the platform.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maxItems: 1
You don't need this, just count the length of the next property:
> +
> + advantech,sub-dev:
> + description:
> + A list of the sub-devices supported in the platform. Defines for the
> + appropriate values can found in dt-bindings/mfd/ahc1ec0-dt.h.
> + $ref: "/schemas/types.yaml#/definitions/uint32-array"
> + minItems: 1
> + maxItems: 6
But as I said before, this binding is odd. It doesn't look like how we
do any other MFD. Either we have child nodes or they are implicit.
> +
> + advantech,hwmon-profile:
> + description:
> + The number of sub-devices specified in the platform. Defines for the
> + hwmon profiles can found in dt-bindings/mfd/ahc1ec0-dt.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maxItems: 1
> +
> +required:
> + - compatible
> + - advantech,sub-dev-nb
> + - advantech,sub-dev
> +
> +if:
> + properties:
> + advantech,sub-dev:
> + contains:
> + const: 0x3
> +then:
> + required:
> + - advantech,hwmon-profile
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/mfd/ahc1ec0-dt.h>
> + ahc1ec0 {
> + compatible = "advantech,ahc1ec0";
> +
> + advantech,sub-dev-nb = <2>;
> + advantech,sub-dev = <AHC1EC0_SUBDEV_HWMON
> + AHC1EC0_SUBDEV_WDT>;
> +
> + advantech,hwmon-profile = <AHC1EC0_HWMON_PRO_UNO2271G>;
> + };
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-02-05 21:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 12:37 [PATCH v6 1/6] MAINTAINERS: Add Advantech AHC1EC0 embedded controller entry Campion Kang
2021-01-18 12:37 ` [PATCH v6 2/6] mfd: ahc1ec0: Add Advantech EC include file used by dt-bindings Campion Kang
2021-02-04 10:32 ` Lee Jones
2021-01-18 12:37 ` [PATCH v6 3/6] dt-bindings: mfd: ahc1ec0.yaml: Add Advantech embedded controller - AHC1EC0 Campion Kang
2021-02-05 21:21 ` Rob Herring [this message]
2021-01-18 12:37 ` [PATCH v6 4/6] mfd: ahc1ec0: Add support for Advantech embedded controller Campion Kang
2021-01-19 7:25 ` AceLan Kao
2021-01-19 8:23 ` Lee Jones
2021-03-09 16:07 ` Lee Jones
2021-03-19 10:01 ` Campion Kang
2021-03-19 14:14 ` Lee Jones
[not found] ` <f47a66c80d8b4cf6b9c28a4519a10521@Taipei11.ADVANTECH.CORP>
2021-03-24 8:44 ` Lee Jones
2021-01-18 12:37 ` [PATCH v6 5/6] hwmon: ahc1ec0-hwmon: Add sub-device hwmon " Campion Kang
2021-01-19 7:26 ` AceLan Kao
2021-01-23 16:35 ` Guenter Roeck
[not found] ` <66338d379bb14c2fbd8a6507075384ce@Taipei11.ADVANTECH.CORP>
2021-01-28 15:13 ` Guenter Roeck
2021-01-18 12:37 ` [PATCH v6 6/6] watchdog: ahc1ec0-wdt: Add sub-device watchdog " Campion Kang
2021-01-19 7:26 ` AceLan Kao
2021-01-23 17:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205212133.GA3759495@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=campion.kang@advantech.com.tw \
--cc=chia-lin.kao@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).