From: Eddie James <eajames@linux.ibm.com>
To: linux-hwmon@vger.kernel.org
Cc: linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org,
jk@ozlabs.org, joel@jms.id.au, alistair@popple.id.au,
jdelvare@suse.com, linux@roeck-us.net,
Eddie James <eajames@linux.ibm.com>
Subject: [PATCH 0/4] occ: fsi and hwmon: Fixes for polling un-initialized OCC
Date: Tue, 9 Feb 2021 11:12:31 -0600 [thread overview]
Message-ID: <20210209171235.20624-1-eajames@linux.ibm.com> (raw)
In the event that the OCC is not initialized when the driver sends a poll
command, the driver may receive an invalid response. This isn't an error
condition unless there is no valid response before the timeout expires. So
change the starting sequence number and check for the un-initialized OCC
state before returning the response in order to detect this condition and
continue waiting if necessary.
Eddie James (4):
fsi: occ: Don't accept response from un-initialized OCC
fsi: occ: Log error for checksum failure
hwmon: (occ) Start sequence number at one
hwmon: (occ) Print response status in first poll error message
drivers/fsi/fsi-occ.c | 11 ++++++++---
drivers/hwmon/occ/common.c | 7 +++++--
2 files changed, 13 insertions(+), 5 deletions(-)
--
2.27.0
next reply other threads:[~2021-02-09 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 17:12 Eddie James [this message]
2021-02-09 17:12 ` [PATCH 1/4] fsi: occ: Don't accept response from un-initialized OCC Eddie James
2021-04-06 7:18 ` Joel Stanley
2021-02-09 17:12 ` [PATCH 2/4] fsi: occ: Log error for checksum failure Eddie James
2021-04-06 7:21 ` Joel Stanley
2021-02-09 17:12 ` [PATCH 3/4] hwmon: (occ) Start sequence number at one Eddie James
2021-02-09 18:12 ` Guenter Roeck
2021-02-09 17:12 ` [PATCH 4/4] hwmon: (occ) Print response status in first poll error message Eddie James
2021-02-09 18:12 ` Guenter Roeck
2021-04-05 15:33 ` [PATCH 0/4] occ: fsi and hwmon: Fixes for polling un-initialized OCC Eddie James
2021-04-06 7:22 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209171235.20624-1-eajames@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=alistair@popple.id.au \
--cc=jdelvare@suse.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).