From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBB1AC433E0 for ; Sat, 6 Mar 2021 04:55:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79B8F65011 for ; Sat, 6 Mar 2021 04:55:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229642AbhCFEy6 (ORCPT ); Fri, 5 Mar 2021 23:54:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:53624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbhCFEym (ORCPT ); Fri, 5 Mar 2021 23:54:42 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6459165004; Sat, 6 Mar 2021 04:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615006481; bh=Wa4Bw26HoIcAUd6ZQXNe09EtrI1nCHJH/RzeHCepf9I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T+GwdOmNNFxHZ9hWHvqkj5fS11o8kpPGKjXzfrWPMKdxUCl5fyz9O6jlXDlbRU42p oSsJ+bIRcJS13KH3iSJdpAYGzZwWRL384hg9lWv5Eh0l8AoGT6P4ABK9n+s9hk9rxf r8Ttggw/m+bTeJnEVxlsFuvy3P5e6AJjiqLdMgm8dWaHFCSDBgN79LxcY6sXHcHEXd dXLdBSXpMJ+unfzLZg5hadmDYuYPBU7eqYxeIsxjTLcKtC4Oz3jhzeQsI8hVulILUS Yf2VWo56OdGrYXoVfy/eSCkrgitFv4dJrOhBMYbyIMb2Q6XHGXoYStcp4v3ADUbu2T Pz/tklQL58P2Q== Date: Fri, 5 Mar 2021 22:54:39 -0600 From: "Gustavo A. R. Silva" To: Guenter Roeck Cc: Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH RESEND][next] hwmon: (max6621) Fix fall-through warnings for Clang Message-ID: <20210306045439.GA179425@embeddedor> References: <20210305095258.GA141583@embeddedor> <20210306031847.GA192807@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210306031847.GA192807@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Hi Guenter, On Fri, Mar 05, 2021 at 07:18:47PM -0800, Guenter Roeck wrote: > On Fri, Mar 05, 2021 at 03:52:58AM -0600, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Acked-by: Guenter Roeck > > Signed-off-by: Gustavo A. R. Silva > > --- > > I Acked those, thus assuming that they would be applied through some > other tree. If that is not the case, you'll need to let me know. The > resend only means to me that whatever tree was supposed to pick it up > did not do it, but it doesn't result in any action from my side. This was not directed at you, in particular. I'm resending this for the cosideration of whomever is in charge of this code. If this is not taken or ignored once again, I will consider adding this to my own tree. Thanks -- Gustavo > > drivers/hwmon/max6621.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/hwmon/max6621.c b/drivers/hwmon/max6621.c > > index 367855d5edae..7821132e17fa 100644 > > --- a/drivers/hwmon/max6621.c > > +++ b/drivers/hwmon/max6621.c > > @@ -156,7 +156,7 @@ max6621_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr, > > default: > > break; > > } > > - > > + break; > > default: > > break; > > } > > -- > > 2.27.0 > >