From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF837C433ED for ; Thu, 20 May 2021 06:49:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B162C61184 for ; Thu, 20 May 2021 06:49:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbhETGuy (ORCPT ); Thu, 20 May 2021 02:50:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbhETGuy (ORCPT ); Thu, 20 May 2021 02:50:54 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 946E0C061574 for ; Wed, 19 May 2021 23:49:33 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id y14so14303038wrm.13 for ; Wed, 19 May 2021 23:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=E1ZuZRCTlz6/Ws9j0pRH14oGlY9lvvE2LqjzptzYfhQ=; b=axSDBqF3Sq8wkc0WbH3CZY6xm95L5mDZQFgCfOftPV9fglwEx33FuoeYTqysdF5CgO gvOAGVJZQq0bB6/K5ulo+fN8Xt1eZcfui9dS+YxqacaFmgLBTh8mXE30GkWIW8mG4gop b0nJpOKu1eMSEZ+P+wGt5ZABOMNItvm0iPiYRFJv+CJh5SovDDgyJ0JY0nRv5zqoWaqy itEp92jB45oI7wAH/FQlDEMKw9mTUrE2qbi7R+h0oBTAjQISeI9YlMa4waCbqKrl2PPq C/dmLBHaaav0k/lPwIQGhyye7uVNYzDQItA2FuQSU7y1eFiI9/+9GnlGjOgxZzuX/enh EoGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=E1ZuZRCTlz6/Ws9j0pRH14oGlY9lvvE2LqjzptzYfhQ=; b=Gj56Sg6kMEOVfZrhwbVeXt30lbjDjDS59Sg3uPAO00H1E2sFXn/aXqjBCHQUfOmAsb gb3qfVUu7FD6GE4FCP/J4oxSIbQICk2NuMACN6A0o3D98iQeXDiUwr/2NSh7rUQOzh7T +gnksAJyJV4vjAsxgWUNQqrYQOhC+AhNC61kaH75C2haLMFrlvTcQ7tY+PnFaL8B0xpc NVG1TO1lH+SLBUZuwgaAwL00us3NGtoSLPTqWkgCIhz6L7sUggpzaddNltBAqDpBPosR 8zVxasxhQpnJoznGRFdKfbmefiiX8Jgtfa/pICcjswBAv/9U7+zI6uPY616qV5ZQPhQV fhQw== X-Gm-Message-State: AOAM533KNi8rmqv0j+Tf1Tn+5uHixaBwE0t3XNLg0aNO6+gxu/QTPTCb yg1EwG9I9Ec8D/0pNXjSeJiGZQ== X-Google-Smtp-Source: ABdhPJwd6qF+Ay8hmUhZ+42UEFFkMLo1dBf7iN0NlNPKX5LqdOy5Y71JWAqSVW/tw0t9av+hXvaRNw== X-Received: by 2002:a5d:4b08:: with SMTP id v8mr2606935wrq.122.1621493372212; Wed, 19 May 2021 23:49:32 -0700 (PDT) Received: from dell ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id p2sm1930764wrj.10.2021.05.19.23.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 23:49:31 -0700 (PDT) Date: Thu, 20 May 2021 07:49:29 +0100 From: Lee Jones To: Michael Walle Cc: Robert Marko , robh+dt@kernel.org, Linus Walleij , bgolaszewski@baylibre.com, jdelvare@suse.com, Guenter Roeck , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org, Luka Perkov , jmp@epiphyte.org, Paul Menzel , Donald Buczek Subject: Re: [PATCH 1/6] mfd: Add Delta TN48M CPLD driver Message-ID: <20210520064929.GM2549456@dell> References: <20210430123511.116057-1-robert.marko@sartura.hr> <0f28cabf858154842819935000f32bc2@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f28cabf858154842819935000f32bc2@walle.cc> Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Wed, 19 May 2021, Michael Walle wrote: > Hi, > > Am 2021-05-19 13:53, schrieb Robert Marko: > > On Thu, May 6, 2021 at 6:34 PM Michael Walle wrote: > > > Am 2021-04-30 14:35, schrieb Robert Marko: > > > > Delta TN48M switches have a Lattice CPLD that serves > > > > multiple purposes including being a GPIO expander. > > > > So lets add the MFD core driver for it. > > > > > > Did you have a look at mfd/simple-mfd-i2c.c? > > > > Yes, that was my first idea but we have a requirement to expose CPLD > > information via debugfs as there are userspace applications using it. > > And simple-mfd-i2c does not allow us to do so. > > Mh, last time Lee wasn't very fond of having a driver that just populates > sub-drivers while doing almost nothing itself. See > https://lore.kernel.org/lkml/20200605065709.GD3714@dell/ Right. I still feel that way. > That being said, I'd also like to expose our CPLD version, but until now > haven't found a good solution. Why though? Does S/W *need* it? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog