* [PATCH] hwmon: (w83627ehf) Make DEVICE_ATTR_RO static
@ 2021-07-24 15:48 W_Armin
2021-07-25 3:21 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: W_Armin @ 2021-07-24 15:48 UTC (permalink / raw)
To: linux; +Cc: jdelvare, linux-hwmon
From: Armin Wolf <W_Armin@gmx.de>
Make DEVICE_ATTR_RO static to fix sparse warning:
warning: symbol 'dev_attr_cpu0_vid' was not declared. Should it be static?
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
drivers/hwmon/w83627ehf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index 3cea66c58c25..705a59663d42 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -1081,7 +1081,7 @@ cpu0_vid_show(struct device *dev, struct device_attribute *attr, char *buf)
struct w83627ehf_data *data = dev_get_drvdata(dev);
return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm));
}
-DEVICE_ATTR_RO(cpu0_vid);
+static DEVICE_ATTR_RO(cpu0_vid);
/* Case open detection */
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (w83627ehf) Make DEVICE_ATTR_RO static
2021-07-24 15:48 [PATCH] hwmon: (w83627ehf) Make DEVICE_ATTR_RO static W_Armin
@ 2021-07-25 3:21 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-07-25 3:21 UTC (permalink / raw)
To: W_Armin; +Cc: jdelvare, linux-hwmon
On Sat, Jul 24, 2021 at 05:48:17PM +0200, W_Armin@gmx.de wrote:
> From: Armin Wolf <W_Armin@gmx.de>
>
> Make DEVICE_ATTR_RO static to fix sparse warning:
> warning: symbol 'dev_attr_cpu0_vid' was not declared. Should it be static?
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/w83627ehf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.20.1
>
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index 3cea66c58c25..705a59663d42 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1081,7 +1081,7 @@ cpu0_vid_show(struct device *dev, struct device_attribute *attr, char *buf)
> struct w83627ehf_data *data = dev_get_drvdata(dev);
> return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm));
> }
> -DEVICE_ATTR_RO(cpu0_vid);
> +static DEVICE_ATTR_RO(cpu0_vid);
>
>
> /* Case open detection */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-25 3:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-24 15:48 [PATCH] hwmon: (w83627ehf) Make DEVICE_ATTR_RO static W_Armin
2021-07-25 3:21 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).