archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <>
To: unlisted-recipients:; (no To-header on input)
Cc: "Randy Dunlap" <>,
	"Pali Rohár" <>,
	"Jean Delvare" <>,
	"Guenter Roeck" <>,,
	"Greg Kroah-Hartman" <>,
	"Arnd Bergmann" <>,, "Armin Wolf" <>
Subject: [PATCH] hwmon: dell-smm-hwmon: fix unused variable error
Date: Fri, 10 Sep 2021 00:19:21 -0700	[thread overview]
Message-ID: <> (raw)

When CONFIG_PROC_FS is not set, there is a build warning (turned
into an error):

../drivers/hwmon/dell-smm-hwmon.c: In function 'i8k_init_procfs':
../drivers/hwmon/dell-smm-hwmon.c:624:24: error: unused variable 'data' [-Werror=unused-variable]
  struct dell_smm_data *data = dev_get_drvdata(dev);

Fix this by making I8K depend on PROC_FS and HWMON (instead of
selecting HWMON -- we prefer and try hard not to select entire

Build tested in all possible combinations of SENSORS_DELL_SMM,
I8K, and PROC_FS.

Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k")
Signed-off-by: Randy Dunlap <>
Cc: Pali Rohár <>
Cc: Jean Delvare <>
Cc: Guenter Roeck <>
Cc: Greg Kroah-Hartman <>
Cc: Arnd Bergmann <>
Cc: Armin Wolf <>
 arch/x86/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20210910.orig/arch/x86/Kconfig
+++ linux-next-20210910/arch/x86/Kconfig
@@ -1255,7 +1255,8 @@ config TOSHIBA
 config I8K
 	tristate "Dell i8k legacy laptop support"
-	select HWMON
+	depends on HWMON
+	depends on PROC_FS
 	  This option enables legacy /proc/i8k userspace interface in hwmon

             reply	other threads:[~2021-09-10  7:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  7:19 Randy Dunlap [this message]
2021-09-10 15:34 ` [PATCH] hwmon: dell-smm-hwmon: fix unused variable error Guenter Roeck
2021-09-10 23:14 ` Pali Rohár
2021-09-20 17:57 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).