From: Paul Fertser <fercerpav@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] hwmon: tmp421: handle I2C errors
Date: Fri, 24 Sep 2021 10:44:50 +0300 [thread overview]
Message-ID: <20210924074450.GU23326@home.paul.comp> (raw)
In-Reply-To: <20210924022020.GA3032273@roeck-us.net>
Hello Guenter,
On Thu, Sep 23, 2021 at 07:20:20PM -0700, Guenter Roeck wrote:
> > --- a/drivers/hwmon/tmp421.c
> > +++ b/drivers/hwmon/tmp421.c
> > @@ -93,7 +93,7 @@ struct tmp421_data {
> > struct hwmon_channel_info temp_info;
> > const struct hwmon_channel_info *info[2];
> > struct hwmon_chip_info chip;
> > - char valid;
> > + bool valid;
>
> This is a cleanup, not a bug fix, and it isn't even mentioned
> in the patch description.
For the bug fix I needed to add a line setting data->valid to false
and was reluctant to assign 0 instead as it would be adding more wrong
(type-wise) code. But since you say that's the way to go, sure, will
do.
Regarding the cleanup, I see hwmon has many examples of "char valid"
and so it might make sense to do them all at once. What would be the
procedure here, is that a desired change at all and if yes, how to
approach doing it?
--
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav@gmail.com
next prev parent reply other threads:[~2021-09-24 7:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 13:41 [PATCH 1/3] hwmon: tmp421: handle I2C errors Paul Fertser
2021-09-22 13:41 ` [PATCH 2/3] hwmon: tmp421: report /PVLD condition Paul Fertser
2021-09-22 13:41 ` [PATCH 3/3] hwmon: tmp421: fix rounding for negative values Paul Fertser
2021-09-22 15:53 ` [PATCH 1/3] hwmon: tmp421: handle I2C errors Guenter Roeck
2021-09-23 9:47 ` [PATCH v2 " Paul Fertser
2021-09-23 9:48 ` [PATCH v2 2/3] hwmon: tmp421: report /PVLD condition Paul Fertser
2021-09-23 9:48 ` [PATCH v2 3/3] hwmon: tmp421: fix rounding for negative values Paul Fertser
2021-09-24 2:21 ` Guenter Roeck
2021-09-24 2:20 ` [PATCH v2 1/3] hwmon: tmp421: handle I2C errors Guenter Roeck
2021-09-24 7:44 ` Paul Fertser [this message]
2021-09-24 11:35 ` Guenter Roeck
2021-09-24 19:52 ` [PATCH] hwmon: cleanup non-bool "valid" data fields Paul Fertser
2021-09-25 13:23 ` Guenter Roeck
2021-10-08 14:21 ` Guenter Roeck
2021-09-24 9:30 ` [PATCH v3 1/3] hwmon: tmp421: handle I2C errors Paul Fertser
2021-09-24 9:30 ` [PATCH v3 2/3] hwmon: tmp421: report /PVLD condition as fault Paul Fertser
2021-09-24 11:59 ` Guenter Roeck
2021-09-24 9:30 ` [PATCH v3 3/3] hwmon: tmp421: fix rounding for negative values Paul Fertser
2021-09-24 12:01 ` Guenter Roeck
2021-09-24 11:58 ` [PATCH v3 1/3] hwmon: tmp421: handle I2C errors Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924074450.GU23326@home.paul.comp \
--to=fercerpav@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).