From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13104C433F5 for ; Thu, 29 Sep 2022 19:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbiI2TdA (ORCPT ); Thu, 29 Sep 2022 15:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbiI2Tc4 (ORCPT ); Thu, 29 Sep 2022 15:32:56 -0400 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 794F713D1FF; Thu, 29 Sep 2022 12:32:54 -0700 (PDT) Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-1280590722dso3032237fac.1; Thu, 29 Sep 2022 12:32:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=TxRiuJ829lvDQE6MzHjZpop4R9yzruWCxiqmDqEFGxU=; b=ez6o4ZB17GvxR6NBJxIjv0Yvh/TXn0Lfm2t0XbL6+VhsEi6ZNwfzutPEiGVMPuqy3v F+hCTdfdyItBk9+KPIqOJCAxmxymx0Kk+RuyALq+mvcmq+6gFDZysc+BnT3vEuQ/nzsa 0vMhx+f1+vYxht4Nx/wcsCHkeYoMeeRko9leMTG95Bn+qAmlz/RKyyCqKr2VvlmdPdA7 uFd7ya7+wkmebwJRO0X77rXTuigypA1ff5aGgKYsXZU3o7P030ik97EeejAzH9Z8tp5f 1QUrnIG4vqdb6LWfFNX4LTdI/zKpGfzpkM72VSz9MfSmsA/jZWujz7dwO8D8l8/x9TAH 4D4Q== X-Gm-Message-State: ACrzQf3jGHEMLB7pGxfA+7ZZWruZdfoXLCpLm9s9OkL+PsmXW2RUI7es szRG16erAqzufX810AehAA== X-Google-Smtp-Source: AMsMyM6oGH3EsQkbKXhwfP4STXGmyq1qwqeuBO/cScEix1MGw+HPOwaySFikQlIGetU38yJNBcbHig== X-Received: by 2002:a05:6870:c148:b0:12b:542c:70f1 with SMTP id g8-20020a056870c14800b0012b542c70f1mr2951571oad.102.1664479972913; Thu, 29 Sep 2022 12:32:52 -0700 (PDT) Received: from macbook.herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id b20-20020a056870b25400b0012c52bd4369sm158773oam.19.2022.09.29.12.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 12:32:52 -0700 (PDT) Received: (nullmailer pid 2615299 invoked by uid 1000); Thu, 29 Sep 2022 19:32:51 -0000 Date: Thu, 29 Sep 2022 14:32:51 -0500 From: Rob Herring To: Naresh Solanki Cc: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Krzysztof Kozlowski , Roland Stigge , linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Marcello Sylvester Bauer Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add binding for max6639 Message-ID: <20220929193251.GA2606428-robh@kernel.org> References: <20220922050718.1079651-1-Naresh.Solanki@9elements.com> <20220922050718.1079651-2-Naresh.Solanki@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922050718.1079651-2-Naresh.Solanki@9elements.com> Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Thu, Sep 22, 2022 at 07:07:17AM +0200, Naresh Solanki wrote: > From: Marcello Sylvester Bauer > > Add Devicetree binding documentation for Maxim MAX6639 temperature > monitor with PWM fan-speed controller. > > Signed-off-by: Marcello Sylvester Bauer > Signed-off-by: Naresh Solanki > --- > .../bindings/hwmon/maxim,max6639.yaml | 112 ++++++++++++++++++ > 1 file changed, 112 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml > new file mode 100644 > index 000000000000..c845fb989af2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml > @@ -0,0 +1,112 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim max6639 > + > +maintainers: > + - Roland Stigge > + > +description: | > + The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM > + fan-speed controller. It monitors its own temperature and one external > + diode-connected transistor or the temperatures of two external diode-connected > + transistors, typically available in CPUs, FPGAs, or GPUs. > + > + Datasheets: > + https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf > + > +properties: > + compatible: > + enum: > + - maxim,max6639 > + > + reg: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + - "fan@0" > + - "fan@1" > + > +additionalProperties: false > + > +patternProperties: > + "^fan@[0-1]$": > + type: object > + description: | > + Represents the two fans and their specific configuration. > + > + properties: > + reg: > + description: | > + The fan number. Addresses are a property of the parent (the fan controller), not the fan. > + items: > + minimum: 0 > + maximum: 1 > + > + pwm-polarity: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1] > + default: 1 > + description: > + PWM output is low at 100% duty cycle when this bit is set to zero. PWM > + output is high at 100% duty cycle when this bit is set to 1. IIRC, the PWM binding provides for this. The parent should probably be a PWM provider. > + > + pulses-per-revolution: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 3, 4] > + default: 2 > + description: > + Value specifying the number of pulses per revolution of the controlled > + FAN. > + > + maxim,rpm-range: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [2000, 4000, 8000, 16000] > + default: 4000 > + description: > + Scales the tachometer counter by setting the maximum (full-scale) value > + of the RPM range for max6639. Is this a property of the fan? How is this maxim specific? The bigger issue here is we need a common fan binding. I'm not inclined to accept any more fan controller bindings with fan properties until we do. Rob