From: Naresh Solanki <naresh.solanki@9elements.com>
To: devicetree@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Naresh Solanki <Naresh.Solanki@9elements.com>
Subject: [PATCH RESEND v6 3/5] hwmon: (pmbus/core): Add rdev in pmbus_data struct
Date: Wed, 14 Dec 2022 09:07:13 +0100 [thread overview]
Message-ID: <20221214080715.2700442-3-Naresh.Solanki@9elements.com> (raw)
In-Reply-To: <20221214080715.2700442-1-Naresh.Solanki@9elements.com>
Add regulator device in pmbus_data & initialize the same during PMBus
regulator register.
Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
---
Change in V5:
- Fix error check for rdev
---
drivers/hwmon/pmbus/pmbus_core.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index b005a1c8ad7e..afd98e639b4f 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -81,6 +81,7 @@ struct pmbus_label {
struct pmbus_data {
struct device *dev;
struct device *hwmon_dev;
+ struct regulator_dev **rdevs;
u32 flags; /* from platform data */
@@ -3095,9 +3096,13 @@ static int pmbus_regulator_register(struct pmbus_data *data)
struct device *dev = data->dev;
const struct pmbus_driver_info *info = data->info;
const struct pmbus_platform_data *pdata = dev_get_platdata(dev);
- struct regulator_dev *rdev;
int i;
+ data->rdevs = devm_kzalloc(dev, sizeof(struct regulator_dev *) * info->num_regulators,
+ GFP_KERNEL);
+ if (!data->rdevs)
+ return -ENOMEM;
+
for (i = 0; i < info->num_regulators; i++) {
struct regulator_config config = { };
@@ -3107,10 +3112,10 @@ static int pmbus_regulator_register(struct pmbus_data *data)
if (pdata && pdata->reg_init_data)
config.init_data = &pdata->reg_init_data[i];
- rdev = devm_regulator_register(dev, &info->reg_desc[i],
+ data->rdevs[i] = devm_regulator_register(dev, &info->reg_desc[i],
&config);
- if (IS_ERR(rdev))
- return dev_err_probe(dev, PTR_ERR(rdev),
+ if (IS_ERR(data->rdevs[i]))
+ return dev_err_probe(dev, PTR_ERR(data->rdevs[i]),
"Failed to register %s regulator\n",
info->reg_desc[i].name);
}
--
2.37.3
next prev parent reply other threads:[~2022-12-14 8:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 8:07 [PATCH RESEND v6 1/5] hwmon: (pmbus/core): Add interrupt support Naresh Solanki
2022-12-14 8:07 ` [PATCH RESEND v6 2/5] hwmon: (pmbus/core): Notify hwmon events Naresh Solanki
2022-12-29 14:46 ` Guenter Roeck
2023-01-03 6:54 ` Naresh Solanki
2022-12-14 8:07 ` Naresh Solanki [this message]
2022-12-14 8:07 ` [PATCH RESEND v6 4/5] hwmon: (pmbus/core): Add regulator event support Naresh Solanki
2022-12-14 8:07 ` [PATCH RESEND v6 5/5] hwmon: (pmbus/core): Notify regulator events Naresh Solanki
2022-12-29 14:40 ` [PATCH RESEND v6 1/5] hwmon: (pmbus/core): Add interrupt support Guenter Roeck
2023-01-03 6:48 ` Naresh Solanki
2023-01-03 12:26 ` Guenter Roeck
2023-01-03 15:26 ` Naresh Solanki
2023-01-03 17:40 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214080715.2700442-3-Naresh.Solanki@9elements.com \
--to=naresh.solanki@9elements.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).