* [PATCH 0/1] hwmon: (asus-ec-sensors) add missing mutex path
@ 2023-01-21 11:17 Eugene Shalygin
2023-01-21 11:17 ` [PATCH 1/1] " Eugene Shalygin
0 siblings, 1 reply; 3+ messages in thread
From: Eugene Shalygin @ 2023-01-21 11:17 UTC (permalink / raw)
To: eugene.shalygin; +Cc: Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel
The board definition for ProArt X570-CREATOR WIFI misses the mutex path,
and because ofthe the driver can not be loaded:
asus-ec-sensors asus-ec-sensors: Hardware access guard mutex name is empty
asus-ec-sensors asus-ec-sensors: Failed to setup state/EC locking: -22
asus-ec-sensors: probe of asus-ec-sensors failed with error -22
The issue was pointed out in a comment at GitHub [1]
[1] https://github.com/zeule/asus-ec-sensors/issues/17#issuecomment-1399174059
Eugene Shalygin (1):
hwmon: (asus-ec-sensors) add missing mutex path
drivers/hwmon/asus-ec-sensors.c | 1 +
1 file changed, 1 insertion(+)
--
2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] hwmon: (asus-ec-sensors) add missing mutex path
2023-01-21 11:17 [PATCH 0/1] hwmon: (asus-ec-sensors) add missing mutex path Eugene Shalygin
@ 2023-01-21 11:17 ` Eugene Shalygin
2023-01-24 13:55 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Eugene Shalygin @ 2023-01-21 11:17 UTC (permalink / raw)
To: eugene.shalygin; +Cc: Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel
Add missing mutex path for ProArt X570-CREATOR WIFI.
Fixes: de8fbac5 (hwmon: (asus-ec-sensors) implement locking via the ACPI global lock)
Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
---
drivers/hwmon/asus-ec-sensors.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index a901e4e33d81..b4d65916b3c0 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -299,6 +299,7 @@ static const struct ec_board_info board_info_pro_art_x570_creator_wifi = {
.sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB | SENSOR_TEMP_VRM |
SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CPU_OPT |
SENSOR_CURR_CPU | SENSOR_IN_CPU_CORE,
+ .mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,
.family = family_amd_500_series,
};
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] hwmon: (asus-ec-sensors) add missing mutex path
2023-01-21 11:17 ` [PATCH 1/1] " Eugene Shalygin
@ 2023-01-24 13:55 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2023-01-24 13:55 UTC (permalink / raw)
To: Eugene Shalygin; +Cc: Jean Delvare, linux-hwmon, linux-kernel
On Sat, Jan 21, 2023 at 12:17:28PM +0100, Eugene Shalygin wrote:
> Add missing mutex path for ProArt X570-CREATOR WIFI.
>
> Fixes: de8fbac5 (hwmon: (asus-ec-sensors) implement locking via the ACPI global lock)
> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
Applied.
The abbreviated SHA in Fixes: tags should include 12 SHA letters/digits.
I fixed that up, but please keep it in mind for future patches.
Thanks,
Guenter
> ---
> drivers/hwmon/asus-ec-sensors.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index a901e4e33d81..b4d65916b3c0 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -299,6 +299,7 @@ static const struct ec_board_info board_info_pro_art_x570_creator_wifi = {
> .sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB | SENSOR_TEMP_VRM |
> SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CPU_OPT |
> SENSOR_CURR_CPU | SENSOR_IN_CPU_CORE,
> + .mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,
> .family = family_amd_500_series,
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-24 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-21 11:17 [PATCH 0/1] hwmon: (asus-ec-sensors) add missing mutex path Eugene Shalygin
2023-01-21 11:17 ` [PATCH 1/1] " Eugene Shalygin
2023-01-24 13:55 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).