linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Crawford <frank@crawford.emu.id.au>
To: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, Frank Crawford <frank@crawford.emu.id.au>
Subject: [PATCH v1 2/7] hwmon: (it87) Disable configuration exit for certain chips
Date: Thu, 26 Jan 2023 15:02:18 +1100	[thread overview]
Message-ID: <20230126040223.986189-3-frank@crawford.emu.id.au> (raw)
In-Reply-To: <20230126040223.986189-1-frank@crawford.emu.id.au>

IT8790E and IT8792E/IT8795E have been identified as chips that can have
issues when disabling configuration mode.

Set to never exit configuration mode.

Signed-off-by: Frank Crawford <frank@crawford.emu.id.au>
---
 drivers/hwmon/it87.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index 7049e81f5af1..c5e46b94f0b8 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -2453,6 +2453,13 @@ static int __init it87_find(int sioaddr, unsigned short *address,
 		break;
 	case IT8792E_DEVID:
 		sio_data->type = it8792;
+		/*
+		 * Disabling configuration mode on IT8792E can result in system
+		 * hang-ups and access failures to the Super-IO chip at the
+		 * second SIO address. Never exit configuration mode on this
+		 * chip to avoid the problem.
+		 */
+		doexit = false;
 		break;
 	case IT8771E_DEVID:
 		sio_data->type = it8771;
@@ -2474,6 +2481,7 @@ static int __init it87_find(int sioaddr, unsigned short *address,
 		break;
 	case IT8790E_DEVID:
 		sio_data->type = it8790;
+		doexit = false;	/* See IT8792E comment above */
 		break;
 	case IT8603E_DEVID:
 	case IT8623E_DEVID:
-- 
2.39.1


  parent reply	other threads:[~2023-01-26  4:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26  4:02 [PATCH v1 0/7] hwmon: (it87) Complete handling multi-chip configuration Frank Crawford
2023-01-26  4:02 ` [PATCH v1 1/7] hwmon: (it87) Allow disabling exiting of configuration mode Frank Crawford
2023-01-26  4:02 ` Frank Crawford [this message]
2023-01-26 13:42   ` [PATCH v1 2/7] hwmon: (it87) Disable configuration exit for certain chips Guenter Roeck
2023-01-26 22:49     ` Frank Crawford
2023-01-26  4:02 ` [PATCH v1 3/7] hwmon: (it87) List full chip model name Frank Crawford
2023-01-26  4:02 ` [PATCH v1 4/7] hwmon: (it87) Add chip_id in some info message Frank Crawford
2023-01-26 13:49   ` Guenter Roeck
2023-01-26 22:54     ` Frank Crawford
2023-01-26  4:02 ` [PATCH v1 5/7] hwmon: (it87) Allow multiple chip IDs for force_id Frank Crawford
2023-01-26  4:02 ` [PATCH v1 6/7] hwmon: (it87) Add new chipset IT87952E Frank Crawford
2023-01-26 13:53   ` Guenter Roeck
2023-01-26 22:58     ` Frank Crawford
2023-01-26  4:02 ` [PATCH v1 7/7] hwmon: (it87) Updated documentation for recent updates to it87 Frank Crawford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126040223.986189-3-frank@crawford.emu.id.au \
    --to=frank@crawford.emu.id.au \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).