From: Guenter Roeck <linux@roeck-us.net>
To: Frank Crawford <frank@crawford.emu.id.au>
Cc: Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v1 4/7] hwmon: (it87) Add chip_id in some info message
Date: Thu, 26 Jan 2023 05:49:54 -0800 [thread overview]
Message-ID: <20230126134954.GA1635195@roeck-us.net> (raw)
In-Reply-To: <20230126040223.986189-5-frank@crawford.emu.id.au>
On Thu, Jan 26, 2023 at 03:02:20PM +1100, Frank Crawford wrote:
> In cases where there are multiple chips, print out which chip is
> referred to, in the informational message.
>
> Signed-off-by: Frank Crawford <frank@crawford.emu.id.au>
> ---
> drivers/hwmon/it87.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index 16394b38dce3..5ca8449887da 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -2505,13 +2505,15 @@ static int __init it87_find(int sioaddr, unsigned short *address,
>
> superio_select(sioaddr, PME);
> if (!(superio_inb(sioaddr, IT87_ACT_REG) & 0x01)) {
> - pr_info("Device not activated, skipping\n");
> + pr_info("Device (DEVID=0x%x) not activated, skipping\n",
> + chip_type);
At this point the textual name (it87_devices[sio_data->type].model)
is already known. I would suggest to print that instead.
Thanks,
Guenter
> goto exit;
> }
>
> *address = superio_inw(sioaddr, IT87_BASE_REG) & ~(IT87_EXTENT - 1);
> if (*address == 0) {
> - pr_info("Base address not set, skipping\n");
> + pr_info("Base address not set (DEVID=0x%x), skipping\n",
> + chip_type);
> goto exit;
> }
>
> --
> 2.39.1
>
next prev parent reply other threads:[~2023-01-26 13:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 4:02 [PATCH v1 0/7] hwmon: (it87) Complete handling multi-chip configuration Frank Crawford
2023-01-26 4:02 ` [PATCH v1 1/7] hwmon: (it87) Allow disabling exiting of configuration mode Frank Crawford
2023-01-26 4:02 ` [PATCH v1 2/7] hwmon: (it87) Disable configuration exit for certain chips Frank Crawford
2023-01-26 13:42 ` Guenter Roeck
2023-01-26 22:49 ` Frank Crawford
2023-01-26 4:02 ` [PATCH v1 3/7] hwmon: (it87) List full chip model name Frank Crawford
2023-01-26 4:02 ` [PATCH v1 4/7] hwmon: (it87) Add chip_id in some info message Frank Crawford
2023-01-26 13:49 ` Guenter Roeck [this message]
2023-01-26 22:54 ` Frank Crawford
2023-01-26 4:02 ` [PATCH v1 5/7] hwmon: (it87) Allow multiple chip IDs for force_id Frank Crawford
2023-01-26 4:02 ` [PATCH v1 6/7] hwmon: (it87) Add new chipset IT87952E Frank Crawford
2023-01-26 13:53 ` Guenter Roeck
2023-01-26 22:58 ` Frank Crawford
2023-01-26 4:02 ` [PATCH v1 7/7] hwmon: (it87) Updated documentation for recent updates to it87 Frank Crawford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126134954.GA1635195@roeck-us.net \
--to=linux@roeck-us.net \
--cc=frank@crawford.emu.id.au \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).