From: Frank Crawford <frank@crawford.emu.id.au>
To: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, Frank Crawford <frank@crawford.emu.id.au>
Subject: [PATCH v3 4/7] hwmon: (it87) Add chip_id in some info message
Date: Sat, 28 Jan 2023 17:03:05 +1100 [thread overview]
Message-ID: <20230128060308.1549707-5-frank@crawford.emu.id.au> (raw)
In-Reply-To: <20230128060308.1549707-1-frank@crawford.emu.id.au>
In cases where there are multiple chips, print out which chip is
referred to, in the informational message.
Signed-off-by: Frank Crawford <frank@crawford.emu.id.au>
---
v3:
* No change.
v2:
* Improved chip description following review.
---
drivers/hwmon/it87.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index 1d9f0c6dfeb9..450f0bfec328 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -2503,13 +2503,15 @@ static int __init it87_find(int sioaddr, unsigned short *address,
superio_select(sioaddr, PME);
if (!(superio_inb(sioaddr, IT87_ACT_REG) & 0x01)) {
- pr_info("Device not activated, skipping\n");
+ pr_info("Device (chip %s ioreg 0x%x) not activated, skipping\n",
+ config->model, sioaddr);
goto exit;
}
*address = superio_inw(sioaddr, IT87_BASE_REG) & ~(IT87_EXTENT - 1);
if (*address == 0) {
- pr_info("Base address not set, skipping\n");
+ pr_info("Base address not set (chip %s ioreg 0x%x), skipping\n",
+ config->model, sioaddr);
goto exit;
}
--
2.39.1
next prev parent reply other threads:[~2023-01-28 6:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 6:03 [PATCH v3 0/7] hwmon: (it87) Complete handling multi-chip configuration Frank Crawford
2023-01-28 6:03 ` [PATCH v3 1/7] hwmon: (it87) Allow disabling exiting of configuration mode Frank Crawford
2023-01-29 20:56 ` Guenter Roeck
2023-01-30 18:42 ` Guenter Roeck
2023-01-30 22:19 ` Frank Crawford
2023-01-31 3:40 ` Guenter Roeck
2023-01-28 6:03 ` [PATCH v3 2/7] hwmon: (it87) Disable configuration exit for certain chips Frank Crawford
2023-01-28 6:03 ` [PATCH v3 3/7] hwmon: (it87) List full chip model name Frank Crawford
2023-01-28 6:03 ` Frank Crawford [this message]
2023-01-28 6:03 ` [PATCH v3 5/7] hwmon: (it87) Allow multiple chip IDs for force_id Frank Crawford
2023-01-28 6:03 ` [PATCH v3 6/7] hwmon: (it87) Add new chipset IT87952E Frank Crawford
2023-01-28 6:03 ` [PATCH v3 7/7] hwmon: (it87) Updated documentation for recent updates to it87 Frank Crawford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230128060308.1549707-5-frank@crawford.emu.id.au \
--to=frank@crawford.emu.id.au \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).