From: Jonathan Cameron <jic23@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: linux-kernel@vger.kernel.org, linux@roeck-us.net,
michal.simek@amd.com, Jonathan Corbet <corbet@lwn.net>,
Jean Delvare <jdelvare@suse.com>,
Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michal Simek <michal.simek@xilinx.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 1/4] devres: Provide krealloc_array
Date: Sat, 11 Mar 2023 19:02:08 +0000 [thread overview]
Message-ID: <20230311190208.7eca8c12@jic23-huawei> (raw)
In-Reply-To: <20230309150334.216760-2-james.clark@arm.com>
On Thu, 9 Mar 2023 15:03:30 +0000
James Clark <james.clark@arm.com> wrote:
> There is no krealloc_array equivalent in devres. Users would have to
> do their own multiplication overflow check so provide one.
>
> Signed-off-by: James Clark <james.clark@arm.com>
Trivial comment inline, but otherwise seems reasonable to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> Documentation/driver-api/driver-model/devres.rst | 1 +
> include/linux/device.h | 10 ++++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
> index 4249eb4239e0..8be086b3f829 100644
> --- a/Documentation/driver-api/driver-model/devres.rst
> +++ b/Documentation/driver-api/driver-model/devres.rst
> @@ -364,6 +364,7 @@ MEM
> devm_kmalloc_array()
> devm_kmemdup()
> devm_krealloc()
> + devm_krealloc_array()
> devm_kstrdup()
> devm_kstrdup_const()
> devm_kvasprintf()
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 1508e637bb26..0dd5956c8516 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -223,6 +223,16 @@ static inline void *devm_kcalloc(struct device *dev,
> {
> return devm_kmalloc_array(dev, n, size, flags | __GFP_ZERO);
> }
> +static inline __realloc_size(3, 4) void * __must_check
> +devm_krealloc_array(struct device *dev, void *p, size_t new_n, size_t new_size, gfp_t flags)
> +{
> + size_t bytes;
> +
> + if (unlikely(check_mul_overflow(new_n, new_size, &bytes)))
> + return NULL;
For consistency with krealloc_array and other stuff in device.h that is
of similar 'shape' add a blank line here.
> + return devm_krealloc(dev, p, bytes, flags);
> +}
> +
> void devm_kfree(struct device *dev, const void *p);
> char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp) __malloc;
> const char *devm_kstrdup_const(struct device *dev, const char *s, gfp_t gfp);
next prev parent reply other threads:[~2023-03-11 19:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 15:03 [PATCH v2 0/4] devres: Provide krealloc_array James Clark
2023-03-09 15:03 ` [PATCH v2 1/4] " James Clark
2023-03-11 19:02 ` Jonathan Cameron [this message]
2023-03-09 15:03 ` [PATCH v2 2/4] hwmon: pmbus: Use devm_krealloc_array James Clark
2023-03-11 19:06 ` Jonathan Cameron
2023-03-09 15:03 ` [PATCH v2 3/4] iio: adc: " James Clark
2023-03-11 19:05 ` Jonathan Cameron
2023-03-09 15:03 ` [PATCH v2 4/4] serial: qcom_geni: " James Clark
2023-03-11 19:18 ` Jonathan Cameron
2023-03-17 11:34 ` James Clark
2023-03-18 17:34 ` Jonathan Cameron
2023-03-20 10:03 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230311190208.7eca8c12@jic23-huawei \
--to=jic23@kernel.org \
--cc=agross@kernel.org \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=andersson@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@arm.com \
--cc=jdelvare@suse.com \
--cc=jirislaby@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).