linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
To: Rob Herring <robh@kernel.org>
Cc: Jack Lo <jack.lo@gtsys.com.hk>,
	devicetree@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml
Date: Fri, 10 Jul 2020 10:08:55 +0800	[thread overview]
Message-ID: <21a3f5a0-6f66-33d2-6def-725743cc67e3@gtsys.com.hk> (raw)
In-Reply-To: <20200709165107.GB498064@bogus>

Hi Rob,

On 10/7/2020 12:51 am, Rob Herring wrote:
> On Wed, Jul 08, 2020 at 12:07:47PM +0800, Chris Ruehl wrote:
>> Add documentation for the newly added DTS support in the shtc1 driver.
>> To align with the drivers logic to have high precision by default
> 
> If 0x70 is the only address, then do:
> 
> reg:
>    const: 0x70

yes, that make sense.

> 
>> +
>> +  sensirion,blocking_io:
> 
> s/_/-/

done!

>> +
>> +examples:
>> +  - |
>> +    i2c1 {
>> +      status = "okay";
> 
> Don't show status in examples.

Thanks for your advice.

updated and patch set v5 is out soon.

Chris

      reply	other threads:[~2020-07-10  2:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08  4:07 [PATCH v4 0/2] shtc1: add support for device tree bindings Chris Ruehl
2020-07-08  4:07 ` [PATCH v4 1/2] hwmon: " Chris Ruehl
2020-07-08  4:07 ` [PATCH v4 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml Chris Ruehl
2020-07-09 16:46   ` Rob Herring
2020-07-09 16:51   ` Rob Herring
2020-07-10  2:08     ` Chris Ruehl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21a3f5a0-6f66-33d2-6def-725743cc67e3@gtsys.com.hk \
    --to=chris.ruehl@gtsys.com.hk \
    --cc=devicetree@vger.kernel.org \
    --cc=jack.lo@gtsys.com.hk \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).