From: Guenter Roeck <linux@roeck-us.net>
To: Mohammed Danish Ali <mohammed.danish.ali.14@gmail.com>,
jdelvare@suse.com, corbet@lwn.net, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: hwmon: ltc4282: Add support for LTC4282
Date: Wed, 15 Mar 2023 14:24:06 -0700 [thread overview]
Message-ID: <269496bb-ccc2-a853-f6cd-c494433cca0a@roeck-us.net> (raw)
In-Reply-To: <CAACz5CVXy6CjgOXF-CUC3Zd54MBWWACd=E4GgwH9=2J1gT9ZSg@mail.gmail.com>
On 3/15/23 14:08, Mohammed Danish Ali wrote:
> Date: Wed, 15 Mar 2023 20:48:17 +0000
>
> Added support for LTC4282: High Current Hot Swap Controller with I2C
> Compatible Monitoring
>
> Signed-off-by: Mohammed Danish Ali <mohammed.danish.ali.14@gmail.com <mailto:mohammed.danish.ali.14@gmail.com>>
> ---
...
> + hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name, data, ltc4282_groups);
include/hwmon/hwmon.h:
/*
* hwmon_device_register_with_groups() and
* devm_hwmon_device_register_with_groups() are deprecated.
*/
Documentation/hwmon/submitting-patches.rst:
* Use devm_hwmon_device_register_with_info() or, if your driver needs a remove
function, hwmon_device_register_with_info() to register your driver with the
hwmon subsystem. Try using devm_add_action() instead of a remove function if
possible. Do not use any of the deprecated registration functions.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please resubmit.
Thanks,
Guenter
parent reply other threads:[~2023-03-15 21:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAACz5CVXy6CjgOXF-CUC3Zd54MBWWACd=E4GgwH9=2J1gT9ZSg@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=269496bb-ccc2-a853-f6cd-c494433cca0a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammed.danish.ali.14@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).