From: Guenter Roeck <linux@roeck-us.net>
To: Vadim Pasternak <vadimp@nvidia.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [Re-send PATCH hwmon-next v2 1/1] hwmon: (mlxreg-fan) Add support for fan drawers capability and present registers
Date: Fri, 19 Mar 2021 14:36:02 -0700 [thread overview]
Message-ID: <27c1929b-f817-8cc2-3947-5e7314f8b538@roeck-us.net> (raw)
In-Reply-To: <20210316120239.1834485-1-vadimp@nvidia.com>
On 3/16/21 5:02 AM, Vadim Pasternak wrote:
> Add support for fan drawer's capability and present registers in order
> to set mapping between the fan drawers and tachometers. Some systems
> are equipped with fan drawers with one tachometer inside. Others with
> fan drawers with several tachometers inside. Using present register
> along with tachometer-to-drawer mapping allows to skip reading missed
> tachometers and expose input for them as zero, instead of exposing
> fault code returned by hardware.
>
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
I had asked for a number of changes to v2. Resending v2 without
addressing anything isn't really helpful.
Guenter
next prev parent reply other threads:[~2021-03-19 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 12:02 [Re-send PATCH hwmon-next v2 1/1] hwmon: (mlxreg-fan) Add support for fan drawers capability and present registers Vadim Pasternak
2021-03-19 21:36 ` Guenter Roeck [this message]
2021-03-21 9:39 ` Vadim Pasternak
2021-03-21 16:12 ` Guenter Roeck
2021-03-21 16:23 ` Vadim Pasternak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27c1929b-f817-8cc2-3947-5e7314f8b538@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).