From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D470C05027 for ; Mon, 6 Feb 2023 14:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231482AbjBFOPS (ORCPT ); Mon, 6 Feb 2023 09:15:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231600AbjBFOO6 (ORCPT ); Mon, 6 Feb 2023 09:14:58 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 814F422A17 for ; Mon, 6 Feb 2023 06:13:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675692805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=02/B40HSR0LR8YaNzHPjtA1YkymmZvawyv7jl3hVYyU=; b=TqpNaqSnkZS9aDXVppLJypNh4i5HMUR7NXPzEpSFYFpt8LXNqMw/+bHgv4mNP6EyKHWUz3 oY4Y7gpzRdQFM3gmDMunRahcQJVp5vfiM2Orrv/V6Xk0z4TxgKSq9XbuoHZgmEaIbk3hOT pOmKb/TuNVTHq0LLcDAGz62ijWRhgdY= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-390-vmJ1mlIUPOysXU8eOyVifw-1; Mon, 06 Feb 2023 09:13:23 -0500 X-MC-Unique: vmJ1mlIUPOysXU8eOyVifw-1 Received: by mail-ed1-f69.google.com with SMTP id eo7-20020a056402530700b004aab4319cedso1441861edb.2 for ; Mon, 06 Feb 2023 06:13:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=02/B40HSR0LR8YaNzHPjtA1YkymmZvawyv7jl3hVYyU=; b=cSLSg3RweoOH8fVpgYu0mjHDX/Aj/g+lExJJQ3KjsNEKlxzMXTcab6EM9EC0UD3gH9 iLLRJ07JSduCh6/3An6fxhUBSWydlx6kP3lePwX1seO0g6KTYiEv4zcOgzhJX2cAYTUA NPop9ujL37gLTs0i+VzGpYHk3Ix2q84Bdz/cgVcR/dgSBtfDBdBzkI7VolXjeDDpEHYi LWlSjTXoCc+dtoppxvq8k+uGM/rmjhCFFnagPUKq7vQSQzHzrsN18DIVdSUoRcO6Bbhk TFp+JZTF/gBZdBmSfwz7cFzTWF9+AS+p7qgEX0z5+aSf54zMBFznfXH8Y4a6md+WoBXF qhbA== X-Gm-Message-State: AO0yUKUrN3KLTLpB0MYb1gUxx8AkdYBRVkEmQuRx+rNEGNqBSBGzRsNU bmKqWsk3hVVPnugIkBi3X/BsXyjm8B0GHCweyGy86bbNC/Yum4Csm5ZFSqD2guhwblpD40tOUif cwUpPbPksTvUJK8r1QqissKM= X-Received: by 2002:a50:ccc6:0:b0:4aa:bae3:f4bd with SMTP id b6-20020a50ccc6000000b004aabae3f4bdmr1823856edj.25.1675692802650; Mon, 06 Feb 2023 06:13:22 -0800 (PST) X-Google-Smtp-Source: AK7set/OmMRaUkWqA9rkq2iEAeoZTCss06qO9F1Xew4pbnxsmaEn1EufcA1OXsVcnJS3wu8Xhm6evA== X-Received: by 2002:a50:ccc6:0:b0:4aa:bae3:f4bd with SMTP id b6-20020a50ccc6000000b004aabae3f4bdmr1823841edj.25.1675692802461; Mon, 06 Feb 2023 06:13:22 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id e14-20020a50d4ce000000b004aab66d34c7sm815563edj.7.2023.02.06.06.13.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 06:13:21 -0800 (PST) Message-ID: <296c2403-9ba3-f070-c939-ec845c7410a1@redhat.com> Date: Mon, 6 Feb 2023 15:13:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/2] platform/x86: dell-ddv: Prefer asynchronous probing Content-Language: en-US, nl To: Armin Wolf , markgross@kernel.org Cc: jdelvare@suse.com, linux@roeck-us.net, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230205205456.2364-1-W_Armin@gmx.de> <20230205205456.2364-3-W_Armin@gmx.de> From: Hans de Goede In-Reply-To: <20230205205456.2364-3-W_Armin@gmx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Hi, On 2/5/23 21:54, Armin Wolf wrote: > During probe, both sensor buffers need to be queried to > initialize the hwmon channels. This might be slow on some > machines, causing a unnecessary delay during boot. > Mark the driver with PROBE_PREFER_ASYNCHRONOUS so that it > can be probed asynchronously. > > Signed-off-by: Armin Wolf Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/dell/dell-wmi-ddv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/platform/x86/dell/dell-wmi-ddv.c b/drivers/platform/x86/dell/dell-wmi-ddv.c > index b7ac483eff12..cffbba5e2d9a 100644 > --- a/drivers/platform/x86/dell/dell-wmi-ddv.c > +++ b/drivers/platform/x86/dell/dell-wmi-ddv.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -872,6 +873,7 @@ MODULE_DEVICE_TABLE(wmi, dell_wmi_ddv_id_table); > static struct wmi_driver dell_wmi_ddv_driver = { > .driver = { > .name = DRIVER_NAME, > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > }, > .id_table = dell_wmi_ddv_id_table, > .probe = dell_wmi_ddv_probe, > -- > 2.30.2 >